Skip to content

Enable SA1000: Spacing around keywords #10446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Feb 11, 2025

Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions draft labels Feb 11, 2025
@h3xds1nz
Copy link
Member

h3xds1nz commented Feb 12, 2025

@xtqqczze That requires actually resolving the 2k+ issues.

I'd recommend adding it as suggestion in this config while we change it to warning on the root one (as you already did): https://github.com/dotnet/wpf/blob/main/src/Microsoft.DotNet.Wpf/src/.editorconfig

Can be then added as a work item in #10270

@xtqqczze xtqqczze marked this pull request as ready for review February 12, 2025 17:45
@xtqqczze xtqqczze requested review from a team as code owners February 12, 2025 17:45
@h3xds1nz
Copy link
Member

@dotnet/wpf-developers Could we merge this? This change is in sync with WF and other repos.

Copy link
Member

@harshit7962 harshit7962 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshit7962 harshit7962 merged commit a7ae27a into dotnet:main Mar 3, 2025
8 checks passed
@harshit7962
Copy link
Member

Thanks @xtqqczze for the contribution.

@xtqqczze xtqqczze deleted the patch-1 branch March 3, 2025 15:00
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants