Skip to content

[StyleCleanUp] Fix spacing around keywords (SA1000) #10602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

h3xds1nz
Copy link
Member

@h3xds1nz h3xds1nz commented Mar 19, 2025

Fixes #10524

Description

Fixes spacing around keywords as per SA1000, the only violations were in System.Xaml.

Customer Impact

Cleaner codebase for developers.

Regression

No.

Testing

Local build.

Risk

None.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners March 19, 2025 10:37
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Mar 19, 2025
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 17.64706% with 56 lines in your changes missing coverage. Please review.

Project coverage is 11.55773%. Comparing base (b360342) to head (0e70882).
Report is 3 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10602         +/-   ##
===================================================
+ Coverage   11.40490%   11.55773%   +0.15282%     
===================================================
  Files           3214        3214                 
  Lines         648458      648458                 
  Branches       71511       71511                 
===================================================
+ Hits           73956       74947        +991     
+ Misses        573340      572253       -1087     
- Partials        1162        1258         +96     
Flag Coverage Δ
Debug 11.55773% <17.64706%> (+0.15282%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lindexi lindexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siagupta0202 siagupta0202 merged commit b6914d7 into dotnet:main Mar 20, 2025
8 checks passed
@siagupta0202
Copy link
Contributor

@h3xds1nz Thank you so much for your efforts!

@h3xds1nz
Copy link
Member Author

@siagupta0202 Thank you for the quick approval <3

@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SA1000: Spacing around keywords
3 participants