Skip to content

Add BitmapImage initialization tests validating fix in #10428 #10623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

h3xds1nz
Copy link
Member

@h3xds1nz h3xds1nz commented Mar 23, 2025

Description

Adds very basic initialization tests for BitmapImage, mostly driven just to provide a test validating fix in #10428.

Also adds reference to System.IO.Packaging for PresentationCore.Tests since otherwise the package ain't present, causing any PresentationCore tests to fail that load types which rely on it as the library cannot be loaded.

Customer Impact

None, just a few more tests validating codebase health.

Regression

No.

Testing

Local build.

Risk

None.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners March 23, 2025 13:54
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Mar 23, 2025
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.58438%. Comparing base (b6914d7) to head (bd2cedf).
Report is 6 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10623         +/-   ##
===================================================
+ Coverage   11.45872%   11.58438%   +0.12565%     
===================================================
  Files           3214        3215          +1     
  Lines         648458      648520         +62     
  Branches       71511       71511                 
===================================================
+ Hits           74305       75127        +822     
+ Misses        572989      572147        -842     
- Partials        1164        1246         +82     
Flag Coverage Δ
Debug 11.58438% <100.00000%> (+0.12565%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@singhashish-wpf singhashish-wpf merged commit 96f02c1 into dotnet:main Mar 25, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants