Skip to content

Making visibility of ScrollViewer as Auto in ComboBox #10660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

siagupta0202
Copy link
Contributor

@siagupta0202 siagupta0202 commented Mar 27, 2025

Fixes #10571

Description

Makes visibility of ScrollViewer as Auto in ComboBox

Customer Impact

Regression

No

Testing

local build pass, tested with sample applications

Risk

Microsoft Reviewers: Open in CodeFlow

@Copilot Copilot AI review requested due to automatic review settings March 27, 2025 05:41
@siagupta0202 siagupta0202 requested review from a team as code owners March 27, 2025 05:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (4)
  • src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/ComboBox.xaml: Language not supported
  • src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.Dark.xaml: Language not supported
  • src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.HC.xaml: Language not supported
  • src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.Light.xaml: Language not supported

@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Mar 27, 2025
@siagupta0202 siagupta0202 moved this to 🏗 In Progress in WPF Fluent Theming Mar 27, 2025
@siagupta0202 siagupta0202 added this to the .NET 10 milestone Mar 27, 2025
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.27485%. Comparing base (0d19d68) to head (afe1973).
Report is 3 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10660         +/-   ##
===================================================
+ Coverage   11.27425%   11.27485%   +0.00060%     
===================================================
  Files           3353        3353                 
  Lines         668062      668062                 
  Branches       74980       74980                 
===================================================
+ Hits           75319       75323          +4     
+ Misses        591489      591487          -2     
+ Partials        1254        1252          -2     
Flag Coverage Δ
Debug 11.27485% <ø> (+0.00060%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dipeshmsft dipeshmsft merged commit 4e488e7 into dotnet:main Mar 28, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ☑ Done in WPF Fluent Theming Mar 28, 2025
@dipeshmsft dipeshmsft modified the milestones: .NET 10, 10.0.0 Apr 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage Win 11 Theming
Projects
Status: ☑ Done
Development

Successfully merging this pull request may close these issues.

Fluent2 ComboBox Missing Scrollbars
4 participants