Skip to content

Replace boxing ArrayLists in UIAutomationClientSideProviders (ClickablePoint) #9430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 31, 2025

Conversation

h3xds1nz
Copy link
Member

@h3xds1nz h3xds1nz commented Jul 20, 2024

Description

This should be the last boxing ArrayList that's still left in UIAutomationClientSideProviders when #9388 would be merged.

  • Adds System.Collections reference to UIAutomationClientSideProviders to allow for generic collections in the first place.
  • Removes two boxing ArrayList instances, both times for CPRect structure in ClickablePoint and ProxySimple class.
  • Makes the static fields readonly and moves the other static field init into the static constructor for readability.
  • Adjusts the CPRect bool methods as readonly since they do not modify struct state.
  • Renames the "al*" params as "list*" to reflect reality this ain't an ArrayList.
  • Adjusts internal comments from "Program" to "Progman".

Customer Impact

Improved performance, decreased allocations.

Regression

No.

Testing

Local build.

Risk

Low.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners July 20, 2024 10:02
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Jul 20, 2024
@rchauhan18
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Kuldeep-MS
Kuldeep-MS previously approved these changes Jan 30, 2025
@Kuldeep-MS
Copy link
Member

@h3xds1nz - could you please resolve the conflicts

@h3xds1nz
Copy link
Member Author

@Kuldeep-MS Done, sorry for the delay.

@Kuldeep-MS Kuldeep-MS merged commit d71c3ce into dotnet:main Jan 31, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants