-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Replace boxing ArrayLists in UIAutomationClientSideProviders (ClickablePoint) #9430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Kuldeep-MS
merged 7 commits into
dotnet:main
from
h3xds1nz:remove-boxing-arraylist-clickpoint
Jan 31, 2025
Merged
Replace boxing ArrayLists in UIAutomationClientSideProviders (ClickablePoint) #9430
Kuldeep-MS
merged 7 commits into
dotnet:main
from
h3xds1nz:remove-boxing-arraylist-clickpoint
Jan 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Kuldeep-MS
previously approved these changes
Jan 30, 2025
@h3xds1nz - could you please resolve the conflicts |
68860a0
to
72fa2f2
Compare
@Kuldeep-MS Done, sorry for the delay. |
Kuldeep-MS
approved these changes
Jan 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Community Contribution
A label for all community Contributions
PR
metadata: Label to tag PRs, to facilitate with triage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should be the last boxing
ArrayList
that's still left inUIAutomationClientSideProviders
when #9388 would be merged.System.Collections
reference toUIAutomationClientSideProviders
to allow for generic collections in the first place.ArrayList
instances, both times forCPRect
structure inClickablePoint
andProxySimple
class.readonly
and moves the other static field init into thestatic constructor
for readability.CPRect
bool methods asreadonly
since they do not modify struct state.ArrayList
.Customer Impact
Improved performance, decreased allocations.
Regression
No.
Testing
Local build.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow