Replace Interlocked.{Compare}Exchange Int32 overloads with generic <bool> variants #9480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
PR
|
The PR looks good to me. @h3xds1nz if you could resolve the merge conflicts please? |
h3xds1nz
force-pushed
the
unconstrain-compare-exchange
branch
from
f32b763 to
9a39289
Compare
|
@siagupta0202 Done, should be fine :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9480 +/- ##
===================================================
- Coverage 10.99508% 10.94612% -0.04896%
===================================================
Files 3215 3215
Lines 648472 648440 -32
Branches 71534 71527 -7
===================================================
- Hits 71300 70979 -321
- Misses 576170 576469 +299
+ Partials 1002 992 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
siagupta0202
approved these changes
Mar 3, 2025
|
@h3xds1nz Thank you so much for all your contributions! |
|
@siagupta0202 Thank you for reviewing :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As dotnet/runtime - #65184 was approved last week and changes were made in the runtime repo to unconstrain the generic overload from class-only behaviour for
Interlocked.ExchangeandInterlocked.CompareExchange, we can adjust the code in the WPF repo for improved code quality as well.Given how few places we rely on
Interlockedfunctionality, this should be easy to review.Customer Impact
None, just internal code quality changes that do not measurably affect performance in any direction.
Regression
No.
Testing
Local build/CI.
Risk
None.
Microsoft Reviewers: Open in CodeFlow