Improve start-up time by not using LINQ-Reflection combo for AccessibilityFeatures #9712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
harshit7962
added
Status:InProgress
Status:Proposed
Included in test pass
Status:Completed
and removed
Status:InProgress
Status:Proposed
labels
|
Thank you, @h3xds1nz, for your consistent and valuable contributions. 😄 |
|
@himgoyalmicro Thank you, happy this reflection bit is gone from startup 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All WPF apps will spend now spend considerable time on startup verifying legacy accessibility switches setting. First it uses reflection to gather
UseNetFx47CompatibleAccessibilityFeatures/UseNetFx471CompatibleAccessibilityFeatures/UseNetFx472CompatibleAccessibilityFeatures, then it orders and creates an array to go through its values, which is just a major overkill and this early it results in a big JITTing overhead besides other things.As I personally don't think those properties are gonna grow in the direction where we would need such an over-engineered solution, I've decided to simplify it. This will improve the start-up time of all WPF apps.
Customer Impact
Improved start-up time, decreased start-up allocations.
Regression
No.
Testing
Local build.
Risk
Low, this removes an over-engineered solution for a simple logic evaluation.
Microsoft Reviewers: Open in CodeFlow