Skip to content

Warn on DNS lookup failures #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions kafka/conn.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,11 +237,13 @@ def connect(self):
socket.AF_UNSPEC,
socket.SOCK_STREAM)
except socket.gaierror as ex:
raise socket.gaierror('getaddrinfo failed for {0}:{1}, '
'exception was {2}. Is your advertised.listeners (called'
'advertised.host.name before Kafka 9) correct and resolvable?'.format(
self._init_host, self._init_port, ex
))
log.warning('DNS lookup failed for {0}:{1},'
' exception was {2}. Is your'
' advertised.listeners (called'
' advertised.host.name before Kafka 9)'
' correct and resolvable?'.format(
self._init_host, self._init_port, ex))
self._gai = []
self._gai_index = 0
else:
# if self._gai already exists, then we should try the next
Expand Down