producer: Set exit timeout to 0 for atexit handler to match __del__ #1126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hit a problem with pytest hitting the atexit handler and waiting for close() timeout forever at teardown. This commit makes atexit close() equivalent to __del__ behavior, namely using timeout of 0 for close() completion. If you need a longer timeout you should be setting it explicitly.
|
+1 |
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 25, 2017
…pkp#1126) Hit a problem with pytest hitting the atexit handler and waiting for close() timeout forever at teardown. This commit makes atexit close() equivalent to __del__ behavior, namely using timeout of 0 for close() completion. If you need a longer timeout you should be setting it explicitly.
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 25, 2017
…pkp#1126) Hit a problem with pytest hitting the atexit handler and waiting for close() timeout forever at teardown. This commit makes atexit close() equivalent to __del__ behavior, namely using timeout of 0 for close() completion. If you need a longer timeout you should be setting it explicitly.
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Oct 6, 2017
…pkp#1126) Hit a problem with pytest hitting the atexit handler and waiting for close() timeout forever at teardown. This commit makes atexit close() equivalent to __del__ behavior, namely using timeout of 0 for close() completion. If you need a longer timeout you should be setting it explicitly.
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Jul 16, 2018
…pkp#1126) Hit a problem with pytest hitting the atexit handler and waiting for close() timeout forever at teardown. This commit makes atexit close() equivalent to __del__ behavior, namely using timeout of 0 for close() completion. If you need a longer timeout you should be setting it explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit a problem with pytest hitting the atexit handler and waiting
for close() timeout forever at teardown.
This commit makes atexit close() equivalent to del behavior,
namely using timeout of 0 for close() completion. If you need a
longer timeout you should be setting it explicitly.