Skip to content

Raise AssertionError when decompression unsupported. Fix #1033 #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2017
Merged

Raise AssertionError when decompression unsupported. Fix #1033 #1159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions kafka/consumer/fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ def send_fetches(self):
if self._client.ready(node_id):
log.debug("Sending FetchRequest to node %s", node_id)
future = self._client.send(node_id, request)
future.error_on_callbacks=True
future.add_callback(self._handle_fetch_response, request, time.time())
future.add_errback(log.error, 'Fetch to node %s failed: %s', node_id)
futures.append(future)
Expand Down Expand Up @@ -550,6 +551,12 @@ def _unpack_message_set(self, tp, messages):
log.exception('StopIteration raised unpacking messageset: %s', e)
raise Exception('StopIteration raised unpacking messageset')

# If unpacking raises AssertionError, it means decompression unsupported
# See Issue 1033
except AssertionError as e:
log.exception('AssertionError raised unpacking messageset: %s', e)
raise

def __iter__(self): # pylint: disable=non-iterator-returned
return self

Expand Down