Ignore MetadataResponses with empty broker list #1506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpkp
changed the title
jeffwidman
reviewed
May 25, 2018
test/test_cluster.py
Outdated
| from kafka.cluster import ClusterMetadata | ||
| from kafka.protocol.metadata import MetadataResponse | ||
|
|
||
| import kafka.common as Errors |
There was a problem hiding this comment.
This is confusing... why import common as Errors? Why not directly import errors as errors or common as common?
There was a problem hiding this comment.
good catch! I removed that line as it is not needed. But generally re: kafka.common -- that line was copy-pasta from a file that was written a long time ago before kafka.common was split into kafka.errors and kafka.structs . The only reason to keep kafka.common is to prevent breaking user code that was written before the change. But for our library code we should use kafka.errors directly.
There was a problem hiding this comment.
That's what I thought... I finished the library cleanup here: #1509 so hopefully this won't happen again...
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 1, 2018
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1494 . The MetadataResponse should be ignored and treated as a failure if the broker list is empty (same as the java client).