Skip to content

Update docs for api_version_auto_timeout_ms #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kafka/consumer/group.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ class KafkaConsumer(six.Iterator):
Default: None
api_version_auto_timeout_ms (int): number of milliseconds to throw a
timeout exception from the constructor when checking the broker
api version. Only applies if api_version set to 'auto'
api version. Only applies if api_version set to None.
connections_max_idle_ms: Close idle connections after the number of
milliseconds specified by this config. The broker closes idle
connections after connections.max.idle.ms, so this avoids hitting
Expand Down
2 changes: 1 addition & 1 deletion kafka/producer/kafka.py
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ class KafkaProducer(object):
various APIs. Example: (0, 10, 2). Default: None
api_version_auto_timeout_ms (int): number of milliseconds to throw a
timeout exception from the constructor when checking the broker
api version. Only applies if api_version set to 'auto'
api version. Only applies if api_version set to None.
metric_reporters (list): A list of classes to use as metrics reporters.
Implementing the AbstractMetricsReporter interface allows plugging
in classes that will be notified of new metric creation. Default: []
Expand Down
10 changes: 7 additions & 3 deletions test/fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,17 @@
def random_string(length):
return "".join(random.choice(string.ascii_letters) for i in range(length))

def version_str_to_list(version_str):
return tuple(map(int, version_str.split('.'))) # e.g., (0, 8, 1, 1)
def version_str_to_tuple(version_str):
"""Transform a version string into a tuple.

Example: '0.8.1.1' --> (0, 8, 1, 1)
"""
return tuple(map(int, version_str.split('.')))

def version():
if 'KAFKA_VERSION' not in os.environ:
return ()
return version_str_to_list(os.environ['KAFKA_VERSION'])
return version_str_to_tuple(os.environ['KAFKA_VERSION'])

def get_open_port():
sock = socket.socket()
Expand Down
4 changes: 2 additions & 2 deletions test/testutil.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
FailedPayloadsError
)
from kafka.structs import OffsetRequestPayload
from test.fixtures import random_string, version_str_to_list, version as kafka_version #pylint: disable=wrong-import-order
from test.fixtures import random_string, version_str_to_tuple, version as kafka_version #pylint: disable=wrong-import-order


def kafka_versions(*versions):
Expand All @@ -43,7 +43,7 @@ def construct_lambda(s):
'<=': operator.le
}
op = op_map[op_str]
version = version_str_to_list(v_str)
version = version_str_to_tuple(v_str)
return lambda a: op(a, version)

validators = map(construct_lambda, versions)
Expand Down