consumer: Exit poll if consumer is closed #2152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caller may invoke poll with long timeout and then end up closing the consumer from another thread e.g. to stop the application. Previously poll forcibly waited for the timeout before existing even though it could do nothing but spin in busy loop for the remainder of the time.
gabriel-tincu
approved these changes
Oct 30, 2020
jeffwidman
approved these changes
Oct 31, 2020
There was a problem hiding this comment.
This makes sense to me, but I'm going to let @dpkp take a look as he knows this section of the code far better than me.
|
This makes sense to me -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caller may invoke poll with long timeout and then end up closing the
consumer from another thread e.g. to stop the application. Previously
poll forcibly waited for the timeout before existing even though it
could do nothing but spin in busy loop for the remainder of the time.
This change is