Skip to content

fix: fail to build with features=tracing #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

joshleeb
Copy link
Contributor

@joshleeb joshleeb commented Oct 20, 2021

This change fixes a type error that occurs when building with the tracing feature. It looks like it may have been introduced in 932351a.

$ cargo c --features=tracing
    Checking dprint-plugin-typescript v0.58.0
error[E0308]: mismatched types
  --> src/format_text.rs:75:36
   |
75 |   ensure_no_specific_syntax_errors(parsed_source).unwrap();
   |                                    ^^^^^^^^^^^^^
   |                                    |
   |                                    expected `&ParsedSource`, found struct `ParsedSource`
   |                                    help: consider borrowing here: `&parsed_source`

For more information about this error, try `rustc --explain E0308`.
error: could not compile `dprint-plugin-typescript` due to previous error

This change fixes a type error that occurs when with the `tracing` feature. It looks like it may have been introduced in 932351a.
@dsherret dsherret merged commit 0d8be38 into dprint:main Oct 29, 2021
@dsherret
Copy link
Member

Thanks @joshleeb! I often accidentally break the tracing build 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants