test: add test for snapshoting during migration #4108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakaz
reviewed
Nov 10, 2024
Comment on lines
+1674
to
+1675
| while await is_saving(nodes[0].client): | ||
| await asyncio.sleep(0.1) |
There was a problem hiding this comment.
Consider using assert_eventually
There was a problem hiding this comment.
I need to declare a new method or update this one but it is used in other files, so lets do it next time
There was a problem hiding this comment.
I don't follow, but anyway it's your call, I do not insist on this
adiholden
reviewed
Nov 13, 2024
adiholden
reviewed
Nov 13, 2024
adiholden
reviewed
Nov 13, 2024
adiholden
reviewed
Nov 13, 2024
adiholden
reviewed
Nov 13, 2024
adiholden
approved these changes
Nov 13, 2024
BorysTheDev
deleted the
add_snapshot_and_replication_during_migration_test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3247