fix: RdbTest.LoadStream3 incorrect file usage #4242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
reviewed
Dec 2, 2024
| @@ -668,15 +659,24 @@ TEST_F(RdbTest, LoadStream2) { | |||
| } | |||
|
|
|||
| TEST_F(RdbTest, LoadStream3) { | |||
| auto ec = LoadRdb("RDB_TYPE_STREAM_LISTPACKS_2.rdb"); | |||
| auto ec = LoadRdb("RDB_TYPE_STREAM_LISTPACKS_3.rdb"); | |||
There was a problem hiding this comment.
It was my bug, It looks I haven't saved it before commit when I wrote it
| TEST_F(RdbTest, LoadStream2) { | ||
| auto ec = LoadRdb("RDB_TYPE_STREAM_LISTPACKS_2.rdb"); | ||
| ASSERT_FALSE(ec) << ec.message(); | ||
| auto res = Run({"XINFO", "STREAM", "mystream"}); | ||
| EXPECT_THAT( | ||
| ASSERT_THAT( |
There was a problem hiding this comment.
I am still not sure why this fails and I don't see how moving SnapshotTooBig below will have any effect or it will somehow stop reproducing since on each test case we initialize everything from the start so i don't see how changing maxmemory of one test case can affect another 🤷
Out of curiosity did you try running the test in a loop in a similar machine as the one it failed ?
There was a problem hiding this comment.
Good idea. But let's merge this fix and I will run the test in a loop.
kostasrim
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: RdbTest.LoadStream3 used incorrect file
fix: change file name to correct
Also, I've moved RdbTest.SnapshotTooBig to the end of the file to check the reproducibility of #4215, because it tests OOM error and I don't have other ideas for now