fix(geo): support case insensitive units #4264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
approved these changes
Dec 5, 2024
|
p.s. I will split the |
|
Is it based on an issue?
…On Thu, Dec 5, 2024, 6:11 AM Andy Dunstall ***@***.***> wrote:
Most GEO commands don't seem to support case insensitive units, so seemed
simplest to move AsciiStrToUpper into ExtractUnit
Such as GEOSEARCH Sicily FROMLONLAT 15 37 BYRADIUS 200 km ASC (copied
from redis docs) would return an error (error) ERR unsupported unit
provided. please use M, KM, FT, MI
------------------------------
You can view, comment on, or merge this pull request online at:
#4264
Commit Summary
- 877bfbc
<877bfbc>
fix(geo): support case insensitive units
File Changes
(1 file <https://github.com/dragonflydb/dragonfly/pull/4264/files>)
- *M* src/server/zset_family.cc
<https://github.com/dragonflydb/dragonfly/pull/4264/files#diff-294d1289b1741ae808c06f38d260077a53dcba7762c845f9677a068568821fc9>
(12)
Patch Links:
- https://github.com/dragonflydb/dragonfly/pull/4264.patch
- https://github.com/dragonflydb/dragonfly/pull/4264.diff
—
Reply to this email directly, view it on GitHub
<#4264>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4BFCFUHA7EGKYAUL2D4CL2EBNKPAVCNFSM6AAAAABTCRZBK2VHI2DSMVQWIX3LMV43ASLTON2WKOZSG4ZDANJSGY3TCOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
no no, Andy found it and he raised a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most
GEOcommands don't seem to support case insensitive units, so seemed simplest to moveAsciiStrToUpperintoExtractUnitSuch as
GEOSEARCH Sicily FROMLONLAT 15 37 BYRADIUS 200 km ASC(copied from redis docs) would return an error(error) ERR unsupported unit provided. please use M, KM, FT, MI