Add autoExpandLevel flag to EntryModel
#130
Merged
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** | ||
| * Indicates till which level the tree should be expanded. If expandLevel is | ||
| * missing or has value of -1 it would meanthat all the levels are expanded (default behaviour). |
There was a problem hiding this comment.
missing space: "meanthat"
bhufmann
reviewed
Jun 11, 2025
| @@ -68,6 +69,7 @@ export interface EntryHeader { | |||
| export function EntryModel<T extends Entry>(normalizer: Normalizer<T>): Normalizer<EntryModel<T>> { | |||
| return createNormalizer<EntryModel<any>>({ | |||
| entries: array(normalizer), | |||
| expandLevel: assertNumber, // TODO - does this work correctly? | |||
There was a problem hiding this comment.
the name of the field is now autoExpandLevel. See the referenced Trace Compass/Incubator PR. See also the TSP update for that: eclipse-cdt-cloud/trace-server-protocol#120
bhufmann
reviewed
Jun 11, 2025
| @@ -84,4 +86,12 @@ export interface EntryModel<T extends Entry> { | |||
| * Array of entry | |||
| */ | |||
| entries: T[]; | |||
|
|
|||
There was a problem hiding this comment.
The TSP update has the exact meaning of the field and you can change the description accordingly.
bhufmann
reviewed
Jun 11, 2025
| * missing or has value of -1 it would meanthat all the levels are expanded (default behaviour). | ||
| * If the expandLevel is set to 1 for example, it will expand till the first nodes under the root | ||
| */ | ||
| expandLevel: number; |
williamsyang-work
force-pushed
the
expand-level-impl
branch
from
2cc906b to
671954f
Compare
williamsyang-work
changed the title
autoExpandLevel flag to EntryModel
williamsyang-work
force-pushed
the
expand-level-impl
branch
from
671954f to
6b54b8e
Compare
bhufmann
requested changes
Jun 12, 2025
| @@ -84,4 +86,16 @@ export interface EntryModel<T extends Entry> { | |||
| * Array of entry | |||
| */ | |||
| entries: T[]; | |||
|
|
|||
| /** | |||
| * Sets the auto-expand level to be used for the input of the tree. | |||
There was a problem hiding this comment.
Change to:
Optional auto-expand level to be used for the input of the tree. If omitted value -1 is assumed.
| * - 1 → Top-level elements are expanded, but not their children | ||
| * - 2 → Top-level elements and their children are expanded, but not grand-children | ||
| */ | ||
| autoExpandLevel: number; |
There was a problem hiding this comment.
the autoExpandLevel is optional. Change to
autoExpandLevel?: number;I'll update the description in the TSP to make it more obvious.
williamsyang-work
force-pushed
the
expand-level-impl
branch
from
6b54b8e to
d9f8723
Compare
bhufmann
reviewed
Jun 12, 2025
| @@ -84,4 +86,10 @@ export interface EntryModel<T extends Entry> { | |||
| * Array of entry | |||
| */ | |||
| entries: T[]; | |||
|
|
|||
| /** | |||
| * Optional auto-expand level to be used for the input of the tree. If omitted value -1 is assumed. | |||
There was a problem hiding this comment.
In the previous version of the PR you described the values and meaning. Please bring them back below this line.
Sets the auto-expand level to be used for the input of the tree. Signed-off-by: Will Yang <william.yang@ericsson.com>
williamsyang-work
force-pushed
the
expand-level-impl
branch
from
d9f8723 to
4820261
Compare
bhufmann
approved these changes
Jun 12, 2025
marcdumais-work
approved these changes
Jun 12, 2025
|
The CI failures seem related to current internet outages, that include the |
williamsyang-work
added a commit
to williamsyang-work/theia-trace-extension
that referenced
this pull request
Jun 12, 2025
Add support for the autoExpandLevel flag to automatically collapse tree nodes beyond the specified depth level. When autoExpandLevel is set, nodes at depths greater than the specified level are automatically collapsed in the tree view. Related to eclipse-cdt-cloud/tsp-typescript-client#130 Signed-off-by: Will Yang <william.yang@ericsson.com>
williamsyang-work
added a commit
to williamsyang-work/theia-trace-extension
that referenced
this pull request
Jun 12, 2025
Add support for the autoExpandLevel flag to automatically collapse tree nodes beyond the specified depth level. When autoExpandLevel is set, nodes at depths greater than the specified level are automatically collapsed in the tree view. Related to eclipse-cdt-cloud/tsp-typescript-client#130 Signed-off-by: Will Yang <william.yang@ericsson.com>
1 task
williamsyang-work
added a commit
to williamsyang-work/theia-trace-extension
that referenced
this pull request
Jun 13, 2025
Add support for the autoExpandLevel flag to automatically collapse tree nodes beyond the specified depth level. When autoExpandLevel is set, nodes at depths greater than the specified level are automatically collapsed in the tree view. Related to eclipse-cdt-cloud/tsp-typescript-client#130 Signed-off-by: Will Yang <william.yang@ericsson.com>
marcdumais-work
merged commit 31e7056
into
eclipse-cdt-cloud:master
14 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds
autoExpandLevelflag to EntryModel.Relates to:
eclipse-tracecompass/org.eclipse.tracecompass#277
eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#196
How to test
Make sure this works with latest tracecompass-server.
Follow-ups
The functionality for the flag, the ability for the front-end to correctly expand / collapse tree nodes based on the value of
autoExpandLevel, needs to be implemented.Review checklist