Fix ST7701 conditional compilation logic for MIPI-DSI support #223
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(lcd): correct conditional compilation logic for ST7701 driver - Fix conditional check to include MIPI-DSI alongside RGB support - Update error message to accurately reflect supported interfaces - Resolve incorrect rejection of MIPI-DSI interface configuration The conditional compilation was missing MIPI-DSI check, causing the driver to incorrectly reject valid MIPI-DSI configurations despite the underlying implementation supporting both RGB and MIPI-DSI.
|
Hi @SinKy-Yan, Sorry for the late. Thank you for pointing out this issue! I will cherry-pick your commit in another PR. |
Lzw655
pushed a commit
that referenced
this pull request
Jul 7, 2025
- Fix conditional check to include MIPI-DSI alongside RGB support - Update error message to accurately reflect supported interfaces - Resolve incorrect rejection of MIPI-DSI interface configuration The conditional compilation was missing MIPI-DSI check, causing the driver to incorrectly reject valid MIPI-DSI configurations despite the underlying implementation supporting both RGB and MIPI-DSI. Closes #223
Lzw655
pushed a commit
that referenced
this pull request
Jul 7, 2025
- Fix conditional check to include MIPI-DSI alongside RGB support - Update error message to accurately reflect supported interfaces - Resolve incorrect rejection of MIPI-DSI interface configuration The conditional compilation was missing MIPI-DSI check, causing the driver to incorrectly reject valid MIPI-DSI configurations despite the underlying implementation supporting both RGB and MIPI-DSI. Closes #223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Summary
Fix conditional compilation logic in the ST7701 LCD driver that incorrectly rejected MIPI-DSI interface configurations.
Changes
ESP_PANEL_DRIVERS_BUS_ENABLE_MIPI_DSIalong with RGB support.#endifcomment to match the revised conditional logic.Problem
The
init()method of the ST7701 driver previously only checked forESP_PANEL_DRIVERS_BUS_ENABLE_RGB, which resulted in MIPI-DSI configurations being incorrectly rejected with the misleading error:Despite this, the underlying function
esp_lcd_new_panel_st7701()and the driver implementation do in fact support both RGB and MIPI-DSI interfaces.Solution
The fix ensures that when either
ESP_PANEL_DRIVERS_BUS_ENABLE_RGBorESP_PANEL_DRIVERS_BUS_ENABLE_MIPI_DSIis defined, the driver will initialize properly. This allows the ST7701 driver to work with MIPI-DSI interfaces, particularly on ESP32-P4 platforms.Testing