Skip to content

feat: check embedding shapes in CosineSimilarityBuilders #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahgraber
Copy link
Contributor

@ahgraber ahgraber commented Jun 9, 2025

It is possible that a knowledge graph might be updated with a different configuration leading to embeddings of different dimension. This change provides an informative error in this case.

It is possible that a knowledge graph might be updated with a different configuration leading to embeddings of different dimension. This change provides an informative error in this case.
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 9, 2025
@jjmachan jjmachan merged commit 10061a8 into explodinggradients:main Jun 17, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants