Feature: improve relationship builders for better async and reduced memory utilization #2077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ahgraber
commented
Jun 13, 2025
ahgraber
commented
- CosineSimilarityBuilder now uses a sharded/chunked similarity calculation to significantly reduce memory requirements
- CosineSimilarityBuilder and JaccardSimilarityBuilder now leverage generate_execution_plan to support async iteration over tasks (for potential future multithreading or improved concurrency)
- Added unit tests
…methods - Refactored the JaccardSimilarityBuilder to use async methods for finding similar embedding pairs. - Introduced a new method `generate_execution_plan` to generate coroutines of comparisons for better tracking and potential concurrency - Updated the `transform` method to utilize the new async functionality. - Added comprehensive test coverage for the new features in the JaccardSimilarityBuilder.
dosubot
bot
added
the
size:XXL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.