Skip to content

Add support for 3DGS .ply files #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for 3DGS .ply files #2256

wants to merge 2 commits into from

Conversation

Meakk
Copy link
Member

@Meakk Meakk commented May 16, 2025

Describe your changes

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated timestamp

Continuous integration

Please check the checkbox of the CI you want to run, then push again on your branch.

  • Style checks
  • Fast CI
  • Coverage cached CI
  • Analysis cached CI
  • WASM docker CI
  • Android docker CI
  • macOS Intel cached CI
  • macOS ARM cached CI
  • Windows cached CI
  • Linux cached CI
  • Other cached CI

@Meakk Meakk self-assigned this May 16, 2025
Copy link

You are modifying versions.json, please update the timestamp as well, this will generate new docker images and caches needed for CI.

@Meakk Meakk changed the title 3dgs ply Add support for 3DGS .ply files May 16, 2025
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 9.37500% with 87 lines in your changes missing coverage. Please review.

Project coverage is 95.26%. Comparing base (3bdde01) to head (75e78d2).

Files with missing lines Patch % Lines
plugins/native/module/vtkF3DPLYReader.cxx 6.45% 87 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2256      +/-   ##
==========================================
- Coverage   95.98%   95.26%   -0.73%     
==========================================
  Files         129      131       +2     
  Lines       11431    11527      +96     
==========================================
+ Hits        10972    10981       +9     
- Misses        459      546      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* @brief VTK Reader for 3D Gaussians in binary .ply file format
*
* Reader for "classic" INRIA .ply files as defined in
* https://repo-sam.inria.fr/fungraph/3d-gaussian-splatting/ Supports 3rd degree spherical
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* https://repo-sam.inria.fr/fungraph/3d-gaussian-splatting/ Supports 3rd degree spherical
* https://repo-sam.inria.fr/fungraph/3d-gaussian-splatting/
* Supports 3rd degree spherical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants