Failed to minify the code from this file

[rbndg]

Failed to minify the code from this file

I keep running to this error with many packages that i'm using in my project, most notably bitcoinjs-lib.

The current solutions provided in the documentation are in my opinion unhelpful, basically requiring other libraries to work with CRA instead of other way around.

I know that this project doesn't want to developer to mess around with webpack/babel settings but allowing the user to skip minification for some files/folders without ejecting would be very helpful or make CRA work libs in node_modules.

Thanks

[gaearon]

I empathize with your frustration but the solution you propose (run Babel with the app config on dependencies) is unsafe and incorrect.

It seems correct from your point of view because it would solve your immediate problem. But I know that if we do this, we’ll get equally frustrated people with different kinds of breakages.

We are tracking this problem in #1125. If you want to send a PR to fix it in the correct way as explained in that issue, you’re most welcome. If you don’t, unfortunately you’ll have to wait for somebody else to come around and fix it.

[gaearon]

(That said there’s also an unrelated problem of Uglify not handling ES6 code which will be fixed separately. But even if we do this, and minification works, your code still won’t work in order browsers.)

[gaearon]

FYI, we're starting the work to compile deps with babel-preset-env in Create React App: #3776

Let us know if you have feedback about how this should work.

[rbndg]

@gaearon I don't have any special work flow for this, I have a gulp task that compiles the dependency in the node_modules folder before I building using CRA and so far it seems to be working for me.

[kirkins]

Hello I just started using react. I'm running react-script build and getting an error similar to the one posted here.

> react-scripts build

Creating an optimized production build...
Failed to compile.

Failed to minify the code from this file: 

 	./node_modules/fb/lib/fb.js:130 

Read more here: http://bit.ly/2tRViJ9

The app works fine with npm start. Is this a babel-webpack issue?

@rbndg can you link to solutions you mentioned?

[rbndg]

@kirkins The issue is that CRA currently doesn't compile dependencies.

So you should either move the dependency to outside of the node_modules folder and run build
or compile the the dependency before you run build

[gaearon]

@kirkins Please follow the link in the error message you posted, it literally explains the problem. If something isn’t clear there we’re happy to clarify but please try to read the information we specifically put at that link URL first 🙂 Thank you!

[kirkins]

@gaearon thanks, I was tired, didn't see the link at first.

I found it last night and made the issue as suggested.

Apparently it's not supposed to work with front-end, but I've already used it and it works perfectly fine in my React app, aside from compiling.

So I want to compile myself as I don't want to re-write the app right now.

I'm getting an error on ::has I'm unfamiliar with the syntax. Is it something from the ES6/ES7 that can't be compiled to ES5? Here is a picture of trying on babel GUI (also have cli and it returned the same):

Is it possible to compile this to ES5?

[gaearon]

Yes, it's probably using a dropped or outdated Babel proposal. Maybe ticking stage-0 will fix it.

[kirkins]

@gaearon thanks seems to be working.

https://www.npmjs.com/package/fb-es5
https://github.com/kirkins/facebook-node-sdk

[remidej]

I'm getting a similar error (Failed to minify the code from this file), but the package that makes the build fail is a dev dependency. Shouldn't it be ignored in a production build?

[gaearon]

If you see this error you are importing that package.

[remidej]

Indeed it's actually a JS file that is only meant for development that is importing it. But how can I remove that file from the build?

[gaearon]

Don’t import it?

Sorry, it’s hard to help based on a vague description. Perhaps you can create a new issue with a reproducing project?