Skip to content

Improve npm run eject description #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 106 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
106 commits
Select commit Hold shift + click to select a range
5a045b4
Improve `npm run eject` description
btnwtn Aug 4, 2016
d1b3142
Merge pull request #1 from btnwtn/btnwtn-improve-eject-description
btnwtn Aug 4, 2016
4dbe43b
Better formatting of command descriptions
btnwtn Sep 10, 2016
5261af2
Fit npm script descriptions to 80 character width
btnwtn Sep 11, 2016
c1e5665
Delete npm-debug.log
btnwtn Sep 11, 2016
6517ea3
Resolve rebase
btnwtn Sep 11, 2016
5767ccc
Remove stray comment
btnwtn Sep 11, 2016
02e9b20
Merge master
btnwtn Sep 11, 2016
e84287a
Remove comment
btnwtn Sep 11, 2016
ec3819b
Small grammatical correction (#367)
antonky Aug 5, 2016
6d2314e
Clarify why we only need css?-autoprefixer in development
gaearon Aug 5, 2016
bf574e5
add shebang to tasks scripts (#376)
apaleslimghost Aug 5, 2016
1fc930a
Tweak Jest default settings (#378)
gaearon Aug 5, 2016
50b207b
Fixed typo (#382)
Nopik Aug 6, 2016
4c5f6ab
Creating a new app in the current directory (#368)
torifat Aug 8, 2016
0877119
Update package.json (#397)
A-gambit Aug 8, 2016
c00791d
Add Object.assign() polyfill (#399)
gaearon Aug 8, 2016
457afbf
Bump case-sensitive-paths-webpack-plugin
gaearon Aug 8, 2016
32d3b31
Add Surge.sh to deploy instructions (#379)
elboman Aug 8, 2016
f44110c
Allow popular test path conventions (#400)
gaearon Aug 8, 2016
60d7321
Make build output more chill
gaearon Aug 8, 2016
652757d
Make missing module output slimmer
gaearon Aug 8, 2016
06cd148
Add React Native Web support (#407)
grigio Aug 9, 2016
82a72cc
Disable dot rule of connect-history-api-fallback (#422)
mxstbr Aug 11, 2016
b3de316
Load favicon through html-loader. (#428)
andreypopp Aug 12, 2016
adb0529
Add a hash to media files even in the devmode. (#446)
arunoda Aug 15, 2016
cda93e0
add otf font format to loaders (#434)
A-gambit Aug 18, 2016
ec9ff20
Deactivate the `new-cap` rule in ESLint (#470)
rricard Aug 22, 2016
230e10f
Add 0.2.2 changelog (#475)
gaearon Aug 22, 2016
0feaf5b
Add migration instructions
gaearon Aug 22, 2016
f41439d
Link to Heroku article
gaearon Aug 22, 2016
e528bd2
Added support for webp images in #442 (#458)
gafemoyano Aug 23, 2016
6965a38
Clarify "homepage" field has special meaning
gaearon Aug 23, 2016
fccf0c5
Correcting typo on README.md (#479)
GautierT Aug 24, 2016
087184d
Clarify 0.3.0 is not out yet
gaearon Aug 25, 2016
342cde9
Fix default package version added by global CLI (#491)
kripod Aug 25, 2016
56b3f68
Use most recent React version (#477)
wdhorton Aug 25, 2016
219ce33
Add missing Changelog entry—thanks @elijahmanor!
gaearon Aug 25, 2016
b2d6d76
Started using babel-preset-latest (#490)
kripod Aug 25, 2016
459d6a3
Prepare for 0.2.3 release
gaearon Aug 25, 2016
0fafa46
Update CHANGELOG.md (#492)
gaearon Aug 25, 2016
cff9fcf
Mark react-scripts as executable
gaearon Aug 28, 2016
85be952
Allow importing static file outside src and node_modules folders (#504)
fson Aug 28, 2016
4aceb3c
Add tarec to the alternatives (#516)
geowarin Aug 29, 2016
0c0f57c
Add instructions on <meta> tags
gaearon Aug 31, 2016
9a32f6d
Add a link back to CRA
gaearon Aug 31, 2016
9488f55
ignore .idea folder (#522)
denofevil Aug 31, 2016
7500793
Add a more prominent link to the guide (#524)
fson Aug 31, 2016
46dd3b9
Typo fix (#526)
coryhouse Aug 31, 2016
d2a01dc
removing no-return-assign lint rule (#528) (#529)
mrscobbler Aug 31, 2016
ebf8a0d
Update Jest (#530)
gaearon Sep 1, 2016
1086150
0.3.0-beta
gaearon Sep 1, 2016
95dcae8
Enable watch implicitly unless on CI (#533)
gaearon Sep 1, 2016
6f5594a
Disable react-constant-elements because of bugs (#534)
gaearon Sep 1, 2016
e47502b
Resolve babel-runtime relative to the config (#535)
gaearon Sep 1, 2016
70535b0
Remove unnecessary describe()
gaearon Sep 1, 2016
38d1faf
Update deps
gaearon Sep 1, 2016
45038c9
Document testing (#538)
gaearon Sep 1, 2016
eb287fa
Add 0.3.0 changelog (#539)
gaearon Sep 1, 2016
711a83b
0.3.0
gaearon Sep 1, 2016
6ca30f5
Ignore coverage folder generated by jest (#541)
ldesplat Sep 2, 2016
367d363
Small testing docs tweaks. (#540)
cpojer Sep 2, 2016
5924a63
Bump Jest
gaearon Sep 2, 2016
95cbb8c
0.3.1
gaearon Sep 2, 2016
5240b60
Add 0.3.1 to changelog
gaearon Sep 2, 2016
e8aa327
Update CONTRIBUTING.md
gaearon Sep 2, 2016
a80ba19
Explain focusing and excluding tests
gaearon Sep 2, 2016
c76c3e8
Update CONTRIBUTING.md
gaearon Sep 2, 2016
11b6045
Fix some typos (#547)
maxdeviant Sep 2, 2016
19b04ec
tagging dev-only code (@remove-on-publish-begin/end) and pre-eject-on…
Jiansen Sep 2, 2016
a09f77e
Clarify some of the comments
gaearon Sep 2, 2016
58ec12a
Made webpack respect NODE_PATH environment variable
Aug 22, 2016
dfc39c2
Removed NODE_PATH from env.js
Aug 22, 2016
29d65bb
Added ability to specify multiple directories in node_path.
Aug 23, 2016
8b7ec28
Tweak how NODE_PATH is handled
gaearon Sep 2, 2016
ca8a450
Add Modulus to list of deployment options (#416)
theworkflow Sep 2, 2016
31ceeaf
Reorder deployment instructions by alphabet + minor tweaks
gaearon Sep 2, 2016
fb4d585
Add src/setupTests.js to specify environment setup for Jest (#545) (#…
gaelollivier Sep 2, 2016
bd14fee
Remove code that is unused after publish (#550)
gaearon Sep 2, 2016
a515ff7
Disable implicit serving of the source files (#551)
gaearon Sep 2, 2016
6287030
Look for HTTPS environment variable (#430)
dceddia Sep 2, 2016
3e12578
Add 0.4.0 changelog
gaearon Sep 2, 2016
a6668c2
0.4.0
gaearon Sep 2, 2016
a0d79ac
Mention npm test in init output
gaearon Sep 2, 2016
c35b806
Clarify proxy instructions in generated app README (#537)
Sep 2, 2016
3880051
Fix tasks
gaearon Sep 2, 2016
03a65fc
Fix typo
gaearon Sep 2, 2016
edd9383
fix typo setupTest.js -> setupTests.js (#555)
Sep 2, 2016
ad332ed
Fix version in CHANGELOG npm install command (#557)
ericf Sep 3, 2016
b46617e
Provide custom onError handler for http-proxy-middleware (#502)
cloudmu Sep 3, 2016
31651e8
Add missing breaking change description from 0.3.0 (#562)
gaearon Sep 3, 2016
d7c4cb0
Fix e2e test (#561)
gaearon Sep 3, 2016
c9aee5b
Document #564
gaearon Sep 3, 2016
9d8a2f9
Adds JSX extension support (#563)
tizmagik Sep 3, 2016
fffcdda
Fix local end-to-end testing flow (#566)
gaearon Sep 3, 2016
9dd60d6
Add 0.4.1 changelog
gaearon Sep 3, 2016
4914615
0.4.1
gaearon Sep 3, 2016
c1161d6
Update Flow instructions (#567)
gaearon Sep 3, 2016
79d4e10
Add a note on decorators
gaearon Sep 3, 2016
93dbdbf
Send proper error response in custom onError handler for httpProxyMid…
cloudmu Sep 5, 2016
4b82f75
Warn about unsupported Node.js versions (#575)
fson Sep 6, 2016
f1a9874
Fix mocking assets with special characters in the file path (#584)
fson Sep 10, 2016
6139e6d
Avoid tons of *.json.gzip-files created in project root when running …
thangngoc89 Sep 10, 2016
9bf7939
Add support for *.jpeg file extension. (#624)
mareksuscak Sep 11, 2016
51f16e7
Bump case-sensitive-paths-webpack-plugin version (#593)
Urthen Sep 11, 2016
eb19f41
Better formatting of command descriptions
btnwtn Sep 10, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions npm-debug.log
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
0 info it worked if it ends with ok
1 verbose cli [ '/usr/local/bin/node', '/usr/local/bin/npm', 'start' ]
2 info using npm@3.10.3
3 info using node@v6.3.1
4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle react-scripts@0.3.0-alpha~prestart: react-scripts@0.3.0-alpha
6 silly lifecycle react-scripts@0.3.0-alpha~prestart: no script for prestart, continuing
7 info lifecycle react-scripts@0.3.0-alpha~start: react-scripts@0.3.0-alpha
8 verbose lifecycle react-scripts@0.3.0-alpha~start: unsafe-perm in lifecycle true
9 verbose lifecycle react-scripts@0.3.0-alpha~start: PATH: /usr/local/lib/node_modules/npm/bin/node-gyp-bin:/Users/newton/Science/create-react-app/node_modules/.bin:/usr/local/bin:.git/safe/../../bin:/Users/newton/.rbenv/shims:/Users/newton/.bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/go/bin
10 verbose lifecycle react-scripts@0.3.0-alpha~start: CWD: /Users/newton/Science/create-react-app
11 silly lifecycle react-scripts@0.3.0-alpha~start: Args: [ '-c', 'node scripts/start.js --debug-template' ]
12 silly lifecycle react-scripts@0.3.0-alpha~start: Returned: code: 1 signal: null
13 info lifecycle react-scripts@0.3.0-alpha~start: Failed to exec start script
14 verbose stack Error: react-scripts@0.3.0-alpha start: `node scripts/start.js --debug-template`
14 verbose stack Exit status 1
14 verbose stack at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:242:16)
14 verbose stack at emitTwo (events.js:106:13)
14 verbose stack at EventEmitter.emit (events.js:191:7)
14 verbose stack at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:40:14)
14 verbose stack at emitTwo (events.js:106:13)
14 verbose stack at ChildProcess.emit (events.js:191:7)
14 verbose stack at maybeClose (internal/child_process.js:852:16)
14 verbose stack at Process.ChildProcess._handle.onexit (internal/child_process.js:215:5)
15 verbose pkgid react-scripts@0.3.0-alpha
16 verbose cwd /Users/newton/Science/create-react-app
17 error Darwin 15.6.0
18 error argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
19 error node v6.3.1
20 error npm v3.10.3
21 error code ELIFECYCLE
22 error react-scripts@0.3.0-alpha start: `node scripts/start.js --debug-template`
22 error Exit status 1
23 error Failed at the react-scripts@0.3.0-alpha start script 'node scripts/start.js --debug-template'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the react-scripts package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error node scripts/start.js --debug-template
23 error You can get information on how to open an issue for this project with:
23 error npm bugs react-scripts
23 error Or if that isn't available, you can get their info via:
23 error npm owner ls react-scripts
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]
15 changes: 11 additions & 4 deletions scripts/init.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/

var chalk = require('chalk');
var fs = require('fs-extra');
var path = require('path');
var spawn = require('cross-spawn');
Expand Down Expand Up @@ -80,14 +81,20 @@ module.exports = function(appPath, appName, verbose, originalDirectory) {
console.log('Success! Created ' + appName + ' at ' + appPath + '.');
console.log('Inside that directory, you can run several commands:');
console.log();
console.log(' * npm start: Starts the development server.');
console.log(' * npm run build: Bundles the app into static files for production.');
console.log(' * npm run eject: Removes this tool. If you do this, you can’t go back!');
console.log(chalk.cyan('npm start'));
console.log(' Starts the development server.');
console.log();
console.log(chalk.cyan('npm run build'));
console.log(' Bundles the app into static files for production.');
console.log();
console.log(chalk.cyan('npm run eject'));
console.log(' Removes this tool and copies build dependencies, configs, and scripts into the app directory.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen shot 2016-09-11 at 16 51 42

The new message looks good to me. But let's wrap this line at 80 characters, so it doesn't break with the "standard" terminal window size.

console.log(' If you do this, you can’t go back!');
console.log();
console.log('We suggest that you begin by typing:');
console.log();
console.log(' cd', cdpath);
console.log(' npm start');
console.log(' ' + chalk.cyan('npm start'));
console.log();
console.log('Happy hacking!');
});
Expand Down