Skip to content

Comparison with is #382

Closed
Closed
@BeneCollyridam

Description

@BeneCollyridam

Code choice

In firebsae_admin/_token_gen.py line 290-291
I noticed the sub-expression: payload.get('v') is 0 and I was wondering if this shouldn't be payload.get('v') == 0.

I know that integers from -5 to 256 are cached in CPython, but I don't think it is good to rely on that when checking for equality (if that is the case).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions