fix: Accept Path-like objects in credential factory functions #510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credential factory functions like
credentials.cert()
currently only acceptstr
typed file paths. But Python 3.4 introduced thepathlib
module and with that a wide range of path-like types. This PR makes it possible to pass these path-like objects directly to our credential factory functions.Basically we are going to treat anything that is accepted by
pathlib.Path
as a valid file path. This constructor has good built-in argument validation, and throwsTypeError
for things that not path-like.Resolves #501