Skip to content

fix(auth): Changing variable from "MemoryCost" to "cpuMemCost" in standard_scrypt method #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

pragatimodi
Copy link
Contributor

@pragatimodi pragatimodi commented Sep 8, 2022

Changing the key value "MemoryCost" returned from standard_scrypt to "cpuMemCost"

RELEASE NOTE: Fixed an incorrect key used to set memory_cost config in auth.UserImportHash.standard_scrypt() API.

RELEASE NOTE: Fixed an incorrect key used to set MemoryCost config in standard_scrypt() API
@prameshj
Copy link

prameshj commented Sep 8, 2022

Can you fix the PR description? I think bug fix 489 is referring to a github issue in a different repo?

@pragatimodi pragatimodi changed the title Bug fix 489 Bug fix - Changing variable from "MemoryCost" to "cpuMemCost" in standard_scrypt method Sep 14, 2022
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@pragatimodi pragatimodi merged commit 9e5b8e3 into firebase:master Sep 14, 2022
@pragatimodi pragatimodi deleted the bug_fix_489 branch September 14, 2022 20:19
@lahirumaramba lahirumaramba changed the title Bug fix - Changing variable from "MemoryCost" to "cpuMemCost" in standard_scrypt method fix(auth): Changing variable from "MemoryCost" to "cpuMemCost" in standard_scrypt method Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants