Fix bug where v1 HTTP used v2 API if callback had len 1 #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlined
force-pushed
the
inlined.https-callable-legacy
branch
from
6c79401 to
bda0f10
Compare
taeold
approved these changes
Aug 16, 2021
| @@ -175,6 +175,25 @@ describe('#onCall', () => { | |||
| }; | |||
| expect(cf.run(data, context)).to.deep.equal({ data, context }); | |||
| }); | |||
|
|
|||
| // Regression test for firebase-functions#947 | |||
inlined
force-pushed
the
inlined.https-callable-legacy
branch
from
28598ae to
1c42eed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Callable API is complex enough that we share code between the v1 and v2 SDKs. The shared code sniffed the callback length to determine which API to surface, but this is a mistake because the callback is customer controlled and they may drop parameters they don't care about. By wrapping the customer-provided handler with a known-sized handler we can fix the sniffing behavior.
Fixes #947