Regression (v10): fresh firebase installation has peerDep error on react-native?

[AviVahl]

Operating System

Fedora 38

Browser Version

N/A

Firebase SDK Version

10.1.0

Firebase SDK Product:

Irrelevant

Describe your project's tooling

Irrelevant

Describe the problem

Saw this after upgrading from v9 to v10.1.0 (now that firebaseui is compatible)
Upon installation, the following peerDep warning appears:
warning "firebase > @firebase/auth > @react-native-async-storage/async-storage@1.19.1" has unmet peer dependency "react-native@^0.0.0-0 || 0.60 - 0.72 || 1000.0.0".

Steps and code to reproduce issue

mkdir firebase-test
cd firebase-test
yarn init -y
yarn add firebase

[pragatimodi]

@hsubox76 Is this related to #7128?

[hsubox76]

Yes, so see that issue for why we added @react-native-async-storage/async-storage as an auth dependency - the React Native version of Auth requires it. This warning won't pop up for React Native users because they'll have the react-native dep (a transitive peerDependency of the async-storage package) installed. Unfortunately it will pop up for non-React Native users, which is the majority.

Fortunately, it's just a warning and shouldn't block development. I do think it's a bad situation for a React-Native-related warning to impact the majority of auth users who have nothing to do with React Native, and we'll do our best to try to find a way to remove it.

I can't currently think of a way, however. We could convert the @react-native-async-storage/async-storage package from a dependency to a peerDependency in our own package.json but that would just give the same warning on install, where the unmet peerDependency is now that package. I think the only solution would be separate top-level package.jsons for the RN bundle vs the main auth bundle, but that would require creating a new NPM package (since this is an npm/yarn install warning and not a module resolution warning, which can use nested package.jsons).

[AviVahl]

npm@9 installs peerdeps by default so this actually ends up installing react-native for end users

[gavinsharp]

npm@9 installs peerdeps by default so this actually ends up installing react-native for end users

And indeed this broke various things in our monorepo when upgrading, since react-native in turn pulled in a conflicting version of react.