Skip to content

Fix: sort document reference by long type id #8673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 17, 2024

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Dec 10, 2024

Document ID supports strings and well as long integers in the format of "id" . When sorting documents by document ID, it should be sorted in the following order:

  1. Long (numeric order)
  2. String (lexicographic order)

@milaGGL milaGGL requested review from a team as code owners December 10, 2024 16:00
Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 32cdcb0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 10, 2024

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (1e8edb7)Merge (f749d6b)Diff
    browser381 kB382 kB+367 B (+0.1%)
    main588 kB589 kB+614 B (+0.1%)
    module381 kB382 kB+367 B (+0.1%)
    react-native382 kB382 kB+367 B (+0.1%)
  • @firebase/firestore-lite

    TypeBase (1e8edb7)Merge (f749d6b)Diff
    browser111 kB111 kB+402 B (+0.4%)
    main153 kB154 kB+635 B (+0.4%)
    module111 kB111 kB+402 B (+0.4%)
    react-native111 kB112 kB+402 B (+0.4%)
  • @firebase/functions

    TypeBase (1e8edb7)Merge (f749d6b)Diff
    browser13.7 kB13.7 kB-1 B (-0.0%)
    main14.2 kB14.2 kB-1 B (-0.0%)
    module13.7 kB13.7 kB-1 B (-0.0%)
  • bundle

    16 size changes

    TypeBase (1e8edb7)Merge (f749d6b)Diff
    firestore (CSI Auto Indexing Disable and Delete)272 kB272 kB+332 B (+0.1%)
    firestore (CSI Auto Indexing Enable)272 kB272 kB+332 B (+0.1%)
    firestore (Persistence)303 kB304 kB+332 B (+0.1%)
    firestore (Query Cursors)249 kB249 kB+332 B (+0.1%)
    firestore (Query)247 kB247 kB+332 B (+0.1%)
    firestore (Read data once)234 kB235 kB+332 B (+0.1%)
    firestore (Read Write w Persistence)328 kB328 kB+332 B (+0.1%)
    firestore (Realtime updates)237 kB237 kB+332 B (+0.1%)
    firestore (Transaction)214 kB214 kB+332 B (+0.2%)
    firestore (Write data)213 kB213 kB+332 B (+0.2%)
    firestore-lite (Query Cursors)91.4 kB103 kB+11.3 kB (+12.3%)
    firestore-lite (Query)87.6 kB98.8 kB+11.3 kB (+12.9%)
    firestore-lite (Read data once)63.0 kB74.3 kB+11.3 kB (+17.9%)
    firestore-lite (Transaction)88.3 kB99.5 kB+11.3 kB (+12.8%)
    firestore-lite (Write data)72.6 kB83.9 kB+11.3 kB (+15.5%)
    functions (call)34.4 kB34.4 kB-1 B (-0.0%)

  • firebase

    TypeBase (1e8edb7)Merge (f749d6b)Diff
    firebase-compat.js797 kB797 kB+329 B (+0.0%)
    firebase-firestore-compat.js346 kB347 kB+329 B (+0.1%)
    firebase-firestore-lite.js119 kB130 kB+11.3 kB (+9.5%)
    firebase-firestore.js440 kB441 kB+361 B (+0.1%)
    firebase-functions-compat.js10.4 kB10.4 kB-1 B (-0.0%)
    firebase-functions.js14.6 kB14.6 kB-2 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/foMGLwZIjH.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 10, 2024

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • AbstractUserDataWriter

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size23.9 kB24.2 kB+300 B (+1.3%)
      size-with-ext-deps93.9 kB94.2 kB+306 B (+0.3%)
    • CollectionReference

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size18.8 kB19.1 kB+300 B (+1.6%)
      size-with-ext-deps88.7 kB89.0 kB+306 B (+0.3%)
    • DocumentReference

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size18.8 kB19.1 kB+300 B (+1.6%)
      size-with-ext-deps88.7 kB89.0 kB+306 B (+0.3%)
    • DocumentSnapshot

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size22.3 kB22.6 kB+300 B (+1.3%)
      size-with-ext-deps92.2 kB92.5 kB+306 B (+0.3%)
    • FieldPath

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size17.8 kB18.1 kB+300 B (+1.7%)
      size-with-ext-deps87.7 kB88.0 kB+306 B (+0.3%)
    • QueryDocumentSnapshot

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size22.3 kB22.6 kB+300 B (+1.3%)
      size-with-ext-deps92.2 kB92.5 kB+306 B (+0.3%)
    • QueryEndAtConstraint

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size41.4 kB41.7 kB+300 B (+0.7%)
      size-with-ext-deps111 kB112 kB+306 B (+0.3%)
    • QueryFieldFilterConstraint

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size39.9 kB40.2 kB+300 B (+0.8%)
      size-with-ext-deps110 kB110 kB+306 B (+0.3%)
    • QuerySnapshot

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size24.2 kB24.5 kB+300 B (+1.2%)
      size-with-ext-deps94.2 kB94.5 kB+306 B (+0.3%)
    • QueryStartAtConstraint

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size41.4 kB41.7 kB+300 B (+0.7%)
      size-with-ext-deps111 kB112 kB+306 B (+0.3%)
    • Transaction

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size50.0 kB50.3 kB+300 B (+0.6%)
      size-with-ext-deps120 kB120 kB+306 B (+0.3%)
    • WriteBatch

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size46.5 kB46.8 kB+300 B (+0.6%)
      size-with-ext-deps117 kB117 kB+306 B (+0.3%)
    • _DocumentKey

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size24.5 kB24.8 kB+300 B (+1.2%)
      size-with-ext-deps94.4 kB94.7 kB+306 B (+0.3%)
    • _FieldPath

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size17.6 kB17.9 kB+300 B (+1.7%)
      size-with-ext-deps87.5 kB87.8 kB+306 B (+0.3%)
    • _internalAggregationQueryToProtoRunAggregationQueryRequest

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size36.0 kB36.3 kB+300 B (+0.8%)
      size-with-ext-deps106 kB106 kB+306 B (+0.3%)
    • _internalQueryToProtoQueryTarget

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size43.7 kB44.0 kB+300 B (+0.7%)
      size-with-ext-deps114 kB114 kB+306 B (+0.3%)
    • addDoc

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size132 kB132 kB+326 B (+0.2%)
      size-with-ext-deps204 kB204 kB+332 B (+0.2%)
    • aggregateQuerySnapshotEqual

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size38.7 kB39.0 kB+300 B (+0.8%)
      size-with-ext-deps109 kB109 kB+306 B (+0.3%)
    • and

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size41.2 kB41.5 kB+300 B (+0.7%)
      size-with-ext-deps111 kB112 kB+306 B (+0.3%)
    • arrayRemove

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size28.6 kB28.9 kB+300 B (+1.0%)
      size-with-ext-deps98.9 kB99.2 kB+306 B (+0.3%)
    • arrayUnion

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size28.6 kB28.9 kB+300 B (+1.0%)
      size-with-ext-deps98.9 kB99.2 kB+306 B (+0.3%)
    • average

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size18.8 kB19.1 kB+300 B (+1.6%)
      size-with-ext-deps88.8 kB89.1 kB+306 B (+0.3%)
    • collection

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size19.5 kB19.8 kB+300 B (+1.5%)
      size-with-ext-deps89.5 kB89.8 kB+306 B (+0.3%)
    • collectionGroup

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size18.5 kB18.8 kB+300 B (+1.6%)
      size-with-ext-deps88.5 kB88.8 kB+306 B (+0.3%)
    • deleteAllPersistentCacheIndexes

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size95.1 kB95.4 kB+326 B (+0.3%)
      size-with-ext-deps167 kB167 kB+332 B (+0.2%)
    • deleteDoc

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size122 kB123 kB+326 B (+0.3%)
      size-with-ext-deps194 kB194 kB+332 B (+0.2%)
    • disableNetwork

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size111 kB111 kB+326 B (+0.3%)
      size-with-ext-deps183 kB183 kB+332 B (+0.2%)
    • disablePersistentCacheIndexAutoCreation

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size95.1 kB95.4 kB+326 B (+0.3%)
      size-with-ext-deps167 kB167 kB+332 B (+0.2%)
    • doc

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size20.1 kB20.4 kB+300 B (+1.5%)
      size-with-ext-deps90.1 kB90.4 kB+306 B (+0.3%)
    • documentId

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size17.9 kB18.2 kB+300 B (+1.7%)
      size-with-ext-deps87.8 kB88.1 kB+306 B (+0.3%)
    • enableIndexedDbPersistence

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size187 kB187 kB+326 B (+0.2%)
      size-with-ext-deps258 kB259 kB+332 B (+0.1%)
    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size223 kB223 kB+326 B (+0.1%)
      size-with-ext-deps295 kB295 kB+332 B (+0.1%)
    • enableNetwork

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size111 kB111 kB+326 B (+0.3%)
      size-with-ext-deps183 kB183 kB+332 B (+0.2%)
    • enablePersistentCacheIndexAutoCreation

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size95.1 kB95.4 kB+326 B (+0.3%)
      size-with-ext-deps167 kB167 kB+332 B (+0.2%)
    • endAt

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size41.5 kB41.8 kB+300 B (+0.7%)
      size-with-ext-deps111 kB112 kB+306 B (+0.3%)
    • endBefore

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size41.5 kB41.8 kB+300 B (+0.7%)
      size-with-ext-deps112 kB112 kB+306 B (+0.3%)
    • executeWrite

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size121 kB122 kB+326 B (+0.3%)
      size-with-ext-deps193 kB194 kB+332 B (+0.2%)
    • getAggregateFromServer

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size119 kB119 kB+326 B (+0.3%)
      size-with-ext-deps190 kB191 kB+332 B (+0.2%)
    • getCountFromServer

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size119 kB119 kB+326 B (+0.3%)
      size-with-ext-deps191 kB191 kB+332 B (+0.2%)
    • getDoc

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size153 kB153 kB+326 B (+0.2%)
      size-with-ext-deps225 kB225 kB+332 B (+0.1%)
    • getDocFromCache

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size103 kB103 kB+326 B (+0.3%)
      size-with-ext-deps175 kB175 kB+332 B (+0.2%)
    • getDocFromServer

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size153 kB153 kB+326 B (+0.2%)
      size-with-ext-deps225 kB225 kB+332 B (+0.1%)
    • getDocs

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size155 kB155 kB+326 B (+0.2%)
      size-with-ext-deps227 kB227 kB+332 B (+0.1%)
    • getDocsFromCache

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size111 kB111 kB+326 B (+0.3%)
      size-with-ext-deps182 kB183 kB+332 B (+0.2%)
    • getDocsFromServer

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size155 kB155 kB+326 B (+0.2%)
      size-with-ext-deps226 kB227 kB+332 B (+0.1%)
    • loadBundle

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size120 kB121 kB+326 B (+0.3%)
      size-with-ext-deps192 kB192 kB+332 B (+0.2%)
    • memoryEagerGarbageCollector

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size83.5 kB83.8 kB+326 B (+0.4%)
      size-with-ext-deps155 kB155 kB+332 B (+0.2%)
    • memoryLocalCache

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size105 kB105 kB+326 B (+0.3%)
      size-with-ext-deps177 kB177 kB+332 B (+0.2%)
    • memoryLruGarbageCollector

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size90.0 kB90.3 kB+326 B (+0.4%)
      size-with-ext-deps161 kB162 kB+332 B (+0.2%)
    • namedQuery

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size95.9 kB96.3 kB+326 B (+0.3%)
      size-with-ext-deps167 kB168 kB+332 B (+0.2%)
    • onSnapshot

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size155 kB156 kB+326 B (+0.2%)
      size-with-ext-deps227 kB227 kB+332 B (+0.1%)
    • onSnapshotsInSync

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size144 kB144 kB+326 B (+0.2%)
      size-with-ext-deps216 kB216 kB+332 B (+0.2%)
    • or

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size41.2 kB41.5 kB+300 B (+0.7%)
      size-with-ext-deps111 kB112 kB+306 B (+0.3%)
    • orderBy

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size19.8 kB20.1 kB+300 B (+1.5%)
      size-with-ext-deps89.8 kB90.1 kB+306 B (+0.3%)
    • persistentLocalCache

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size183 kB183 kB+326 B (+0.2%)
      size-with-ext-deps255 kB255 kB+332 B (+0.1%)
    • persistentMultipleTabManager

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size218 kB219 kB+326 B (+0.1%)
      size-with-ext-deps290 kB291 kB+332 B (+0.1%)
    • persistentSingleTabManager

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size182 kB183 kB+326 B (+0.2%)
      size-with-ext-deps254 kB255 kB+332 B (+0.1%)
    • query

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size41.5 kB41.8 kB+300 B (+0.7%)
      size-with-ext-deps112 kB112 kB+306 B (+0.3%)
    • queryEqual

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size38.6 kB38.9 kB+300 B (+0.8%)
      size-with-ext-deps109 kB109 kB+306 B (+0.3%)
    • refEqual

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size19.0 kB19.3 kB+300 B (+1.6%)
      size-with-ext-deps89.0 kB89.3 kB+306 B (+0.3%)
    • runTransaction

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size132 kB133 kB+326 B (+0.2%)
      size-with-ext-deps204 kB204 kB+332 B (+0.2%)
    • setDoc

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size131 kB131 kB+326 B (+0.2%)
      size-with-ext-deps203 kB203 kB+332 B (+0.2%)
    • setIndexConfiguration

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size98.6 kB98.9 kB+326 B (+0.3%)
      size-with-ext-deps170 kB170 kB+332 B (+0.2%)
    • snapshotEqual

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size44.3 kB44.6 kB+300 B (+0.7%)
      size-with-ext-deps114 kB115 kB+306 B (+0.3%)
    • startAfter

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size41.5 kB41.8 kB+300 B (+0.7%)
      size-with-ext-deps112 kB112 kB+306 B (+0.3%)
    • startAt

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size41.5 kB41.8 kB+300 B (+0.7%)
      size-with-ext-deps111 kB112 kB+306 B (+0.3%)
    • sum

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size18.8 kB19.1 kB+300 B (+1.6%)
      size-with-ext-deps88.8 kB89.1 kB+306 B (+0.3%)
    • updateDoc

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size132 kB132 kB+326 B (+0.2%)
      size-with-ext-deps204 kB204 kB+332 B (+0.2%)
    • waitForPendingWrites

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size111 kB112 kB+326 B (+0.3%)
      size-with-ext-deps183 kB183 kB+332 B (+0.2%)
    • where

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size40.7 kB41.0 kB+300 B (+0.7%)
      size-with-ext-deps111 kB111 kB+306 B (+0.3%)
    • writeBatch

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size134 kB134 kB+326 B (+0.2%)
      size-with-ext-deps205 kB206 kB+332 B (+0.2%)
  • @firebase/functions

    • FunctionsError

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size2.52 kB2.52 kB-1 B (-0.0%)
      size-with-ext-deps20.3 kB20.3 kB-1 B (-0.0%)
    • connectFunctionsEmulator

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size2.50 kB2.50 kB-1 B (-0.0%)
      size-with-ext-deps20.4 kB20.4 kB-1 B (-0.0%)
    • getFunctions

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size2.68 kB2.68 kB-1 B (-0.0%)
      size-with-ext-deps28.2 kB28.2 kB-1 B (-0.0%)
    • httpsCallable

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size8.45 kB8.45 kB-1 B (-0.0%)
      size-with-ext-deps26.4 kB26.4 kB-1 B (-0.0%)
    • httpsCallableFromURL

      Size

      TypeBase (1e8edb7)Merge (f749d6b)Diff
      size8.35 kB8.34 kB-1 B (-0.0%)
      size-with-ext-deps26.2 kB26.2 kB-1 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7mEUWKjAHl.html

@milaGGL milaGGL requested a review from ehsannas December 12, 2024 21:14
@milaGGL milaGGL merged commit 32bf021 into main Dec 17, 2024
50 checks passed
@milaGGL milaGGL deleted the mila/fix-sdk-sort-document-reference-bug branch December 17, 2024 16:12
@firebase firebase locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants