Skip to content

chore(issue-template): ask for machine specification and provide link to security policy #3447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2024

Conversation

aldy505
Copy link
Collaborator

@aldy505 aldy505 commented Nov 27, 2024

To remove roundtrip of asking people "what's your machine specification look like?"

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (be02e0e) to head (cbda363).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3447   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files           3        3           
  Lines         203      203           
=======================================
  Hits          201      201           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I don't watch issues anymore for some time and I don't know how many times this occurs (needing to know the specification of user machine).

How many times knowing operating system of user helps us?
How many times knowing specifications of user's hard drive helps us?
And correct me if I'm wrong, but install.sh checks memory and warns users if it does not meet specifications, right?

@bc-sentry
Copy link

Similar sentiment to @aminvakil. We can ask for this information, but it would seem to be marginally useful if other users ran into a machine-specific installation or runtime issue. On the flip side, by adding this field I wouldn't want it to imply to the poster that we will have some ability to try and reproduce their issue on that hardware. In most cases, we do not have the bandwidth to reproduce issues and make a best effort try to respond with advice and/or transfer the issue to a product-specific team for triage.

@BYK
Copy link
Member

BYK commented Nov 27, 2024

I propose adding a checkbox saying something like "My system meets the minimum system requirements of Sentry" instead of asking for specs.

@aldy505
Copy link
Collaborator Author

aldy505 commented Nov 27, 2024

I propose adding a checkbox saying something like "My system meets the minimum system requirements of Sentry" instead of asking for specs.

That sounds better.

@aldy505
Copy link
Collaborator Author

aldy505 commented Nov 29, 2024

This will be delayed, since I need to remember which of my device did I use to create this PR.....

@BYK
Copy link
Member

BYK commented Nov 29, 2024

@aldy505 you can always do gh pr checkout 3447 if you use GitHub CLI 😉

@aldy505
Copy link
Collaborator Author

aldy505 commented Nov 29, 2024

@aldy505 you can always do gh pr checkout 3447 if you use GitHub CLI 😉

I know but I'm too lazy lol. Let me just find my device.

@aldy505 aldy505 requested a review from BYK November 30, 2024 01:45
@aldy505
Copy link
Collaborator Author

aldy505 commented Nov 30, 2024

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😎

@BYK BYK merged commit 56db0db into getsentry:master Nov 30, 2024
12 checks passed
@aldy505 aldy505 deleted the chore/issue-template/machine-spec branch November 30, 2024 10:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants