Skip to content

Bump docker-compose 2.33.1 #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2025
Merged

Conversation

aminvakil
Copy link
Collaborator

Fixes #3596.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@aminvakil
Copy link
Collaborator Author

It will use master branch even in this PR, so it still shows 083f676 in this PR.

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.32.4 also seems to have the issue fixed?

I'm all in for the latest version, just curious:

  1. How were we able to set the version to 2.32.3 which was broken?
  2. Shall we go with the latest or the minimum that fixes the issue

@BYK BYK merged commit e883f21 into getsentry:master Mar 2, 2025
5 checks passed
@aminvakil aminvakil deleted the docker_compose_2.33.1 branch March 3, 2025 04:35
@aminvakil
Copy link
Collaborator Author

2.32.4 also seems to have the issue fixed?

I'm all in for the latest version, just curious:

1. How were we able to set the version to 2.32.3 which was broken?

2. Shall we go with the latest or the minimum that fixes the issue

I thought we can bump minimum requirement to 2.32.4, but I couldn't see a reason not to use latest release in our GHA.

@aminvakil
Copy link
Collaborator Author

  1. How were we able to set the version to 2.32.3 which was broken?
$ vergte 2.33.3 12d3fr32
1
$ vergte 2.33.3 02d3fr32
0

I tested this locally and this results came up, but I didn't go through sort --version-sort and how it works in this case.

function vergte() {
  printf "%s\n%s" $1 $2 | sort --version-sort --check=quiet --reverse
  echo $?
}

@BYK
Copy link
Member

BYK commented Mar 3, 2025

I thought we can bump minimum requirement to 2.32.4, but I couldn't see a reason not to use latest release in our GHA.

Agreed, thanks a lot!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

docker compose version in GHA
2 participants