-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add missing lib script to sentry-admin.sh #3693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya, thanks for the PR! That said I don't think _lib.sh
is needed in this script. I haven't seen anything referring to that and we actually test the backup and restore functionality using this script.
Can you share what kind of an error you are encountering for us to understand this better?
Hey @BYK i got Issues that function vergte is unknow when ever I execute sentry-admin.sh no matter which parameter i add. After debugging I found that install/dc-detect-version.sh need this function. After fixing this locally, the script runs normaly. |
Ah, right sorry! Yeah, since that |
What do you say about moving vergte function to another file and only including that? I'm seeing this in
There may be another problems as well. |
@aminvakil yeah that makes total sense and probably explains the failure. I'll give this a go today |
Sentry Admin Script always fail because of missing import of lib script.
Fixes #3700.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.