Simplify error handling in finishCheckIn callback.

[0xbad0c0d3]

Throwing an error inside catch block will produce unhandled exception and, as a result - crash.
fixes #16749

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[andreiborza]

Hi, unfortunately this ends up swallowing errors in cron jobs. See #14163.

We need to figure out a different way.

[0xbad0c0d3]

yarn build:tarball
yarn workspace @sentry-internal/e2e-tests test:run nestjs-11 //23/23 passed
yarn workspace @sentry-internal/e2e-tests test:run nestjs-basic //23/23 passed
yarn workspace @sentry-internal/e2e-tests test:run nestjs-fastify //24/24 passed

Something seems wrong with the tests

[andreiborza]

Hmmm.. true, nestjs-basic should not pass 🤔

[cursor]

Bug: Error Handling Broken by Silent Error Swallowing

The error callback now silently swallows errors by removing the error parameter and the throw e; statement. This prevents error propagation, breaking error handling patterns and making debugging difficult. It leads to silent failures, particularly impacting error handling in cron jobs as confirmed by PR discussions.

packages/core/src/exports.ts#L181-L184

sentry-javascript/packages/core/src/exports.ts

Lines 181 to 184 in a07bc49

	},
	() => {
	finishCheckIn('error');
	},

Fix in Cursor

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[andreiborza]

Okay, so it does break the test correctly: https://github.com/getsentry/sentry-javascript/actions/runs/15971148094/job/45042700104?pr=16757#step:14:123

[0xbad0c0d3]

Okay, so it does break the test correctly: https://github.com/getsentry/sentry-javascript/actions/runs/15971148094/job/45042700104?pr=16757#step:14:123

Yes, for some reason it does break in CI but it does not break other ways... But maybe I am doing something wrong?

[andreiborza]

Mhm, hard to tell. Either way, we need to think of some other way. I'll try to bring this up today in team discussions and we'll see how to handle it.