Skip to content

Django urlconf callback #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Django urlconf callback #1302

wants to merge 11 commits into from

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Jan 13, 2022

One of our customers have a django-tenants multi-tenant setup. They have a dynamically resolved urlconf and set ROOT_URLCONF to an empty string which breaks this get_resolver in Django.

This results in a silent exception when we try to update the transaction name and hence they see Generic WSGI request for all their requests.

The solution to this is to expose urlconf in DjangoIntegration. The RavenResolver.resolve function already has this as an argument. I extended it to also allow the user to pass in a callback which these users need for their dynamic urlconf.

https://getsentry.atlassian.net/browse/WEB-530

@sl0thentr0py
Copy link
Member Author

closing this because I believe I found a cleaner solution in
#1308

@antonpirker antonpirker deleted the django-urlconf-callbacl branch April 19, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant