Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our customers have a
django-tenants
multi-tenant setup. They have a dynamically resolvedurlconf
and setROOT_URLCONF
to an empty string which breaks thisget_resolver
in Django.This results in a silent exception when we try to update the transaction name and hence they see
Generic WSGI request
for all their requests.The solution to this is to expose
urlconf
inDjangoIntegration
. TheRavenResolver.resolve
function already has this as an argument. I extended it to also allow the user to pass in a callback which these users need for their dynamicurlconf
.https://getsentry.atlassian.net/browse/WEB-530