Skip to content

(Partially) fix POTel CI #4307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

(Partially) fix POTel CI #4307

merged 3 commits into from
Apr 16, 2025

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Apr 16, 2025

Porting stuff from master and other fixes

  • add correct event_level to new logging tests (on potel-base, we don't capture logging errors by default so this has to be set explicitly)
  • add compat for start_transaction
  • re-enable an old test

Note: This still leaves one failing threading test, will address that separately

Copy link

codecov bot commented Apr 16, 2025

❌ 11 Tests Failed:

Tests completed Failed Passed Skipped
20340 11 20329 4403
View the top 3 failed test(s) by shortest run time
tests.integrations.threading.test_threading test_spans_from_multiple_threads[propagate_scope=False]
Stack Traces | 0.104s run time
.../integrations/threading/test_threading.py:246: in test_spans_from_multiple_threads
    (event,) = events
E   ValueError: too many values to unpack (expected 1)
tests.integrations.threading.test_threading test_spans_from_multiple_threads[propagate_scope=False]
Stack Traces | 0.104s run time
.../integrations/threading/test_threading.py:246: in test_spans_from_multiple_threads
    (event,) = events
E   ValueError: too many values to unpack (expected 1)
tests.integrations.threading.test_threading test_spans_from_multiple_threads[propagate_scope=False]
Stack Traces | 0.104s run time
.../integrations/threading/test_threading.py:246: in test_spans_from_multiple_threads
    (event,) = events
E   ValueError: too many values to unpack (expected 1)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sentrivana sentrivana marked this pull request as ready for review April 16, 2025 09:42
@sentrivana sentrivana requested a review from a team as a code owner April 16, 2025 09:42
@sentrivana sentrivana changed the title Fix POTel CI (Partially) fix POTel CI Apr 16, 2025
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see questions and suggestion before merge

@sentrivana sentrivana merged commit 571ff3b into potel-base Apr 16, 2025
115 of 129 checks passed
@sentrivana sentrivana deleted the ivana/potel/fix-ci branch April 16, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants