Fix resolution comment length bug when migrating Secret Scanning alerts #1349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When migrating secret scanning alerts with
gh gei migrate-secret-alerts
, if the new comment format[@resolverName] originalComment
exceeds 270 characters, the GitHub API call fails with an error about comment length limits.This was introduced in PR #1337 which added the resolver name prefix to resolution comments, but didn't account for the 270 character limit.
Solution
Added length validation before using the prefixed comment format:
[@resolverName] originalComment
is < 270 characters: use the prefixed format (preserves existing behavior)[@resolverName] originalComment
is >= 270 characters: fall back to using only the original commentThis ensures migration completes successfully while preserving the most important content when length limits are exceeded.
Changes
Update_With_Long_Comment_Uses_Original_Comment_Only
- verifies fallback behaviorUpdate_With_Short_Comment_Uses_Prefixed_Comment
- ensures existing behavior preservedExample
All existing tests pass. The fix is minimal and preserves all existing functionality while gracefully handling the edge case.
Fixes #1348.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
http://www.microsoft.com:80/pkiops/crl/Microsoft%20Identity%20Verification%20Root%20Certificate%20Authority%202020.crl
dotnet build src/OctoshiftCLI.sln
(http block)http://www.microsoft.com:80/pkiops/crl/Microsoft%20Public%20RSA%20Timestamping%20CA%202020.crl
dotnet build src/OctoshiftCLI.sln
(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.