Support dropping foreign key #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 624 629 +5
=========================================
+ Hits 624 629 +5
☔ View full report in Codecov by Sentry. |
|
Hi, thanks for the PR can you give example what's the use case for mapper? thanks |
|
Thanks for the review.
For the MySQL adapter, func DropKeyMapper(keyType rel.KeyType) string {
if keyType == rel.ForeignKey {
// see https://dev.mysql.com/doc/refman/8.0/ja/alter-table.html
return "FOREIGN KEY"
}
// unsupported key type
// (maybe we should return an error here)
return ""
} |
|
will you update the other adapters too? |
yes I will. |
youpy
added a commit
to youpy/mysql
that referenced
this pull request
Jul 7, 2023
- update `github.com/go-rel/sql` to the latest version - go-rel/sql#50
Fs02
pushed a commit
to go-rel/mysql
that referenced
this pull request
Jul 8, 2023
* Support dropping foreign key - update `github.com/go-rel/sql` to the latest version - go-rel/sql#50 * Unsupported key types cause panic instead of returning "" * Add test for panic on unsupported key drop
This was referenced Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DropKeyMapperthat returns keywords in foreign key deletion based on key type