Skip to content

Update Playing Videos page for Godot 4.5 #10972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

berarma
Copy link
Contributor

@berarma berarma commented May 28, 2025

Removed another limitation: change playback speed.

Added Shutter Encoder as a FFmpeg GUI. Related to #10942.

I've decided to remove the date from the FFmpeg warning since they have already released a point version but without the fix. And I don't know how many more they will release yet. I hoped that the next major version was closer to being released.

Changed the GOP description a bit to hopefully better fit the rest of the documentation.

@skyace65
Copy link
Contributor

What specifically in this PR only applies to 4.5?

@berarma
Copy link
Contributor Author

berarma commented May 29, 2025

What specifically in this PR only applies to 4.5?

I've removed some limitations. I've taken the opportunity to rework some of the text I did previously, and reference Shutter Encoder.

@skyace65
Copy link
Contributor

skyace65 commented Jun 8, 2025

Got it. This needs to be rebased since I just merged #10721. Also is there a reason this is marked as a draft?

@berarma
Copy link
Contributor Author

berarma commented Jun 8, 2025

Oh, sorry, I had forgot about that PR. There's another limitation to remove. I'll do it in this PR.

It's marked as a draft because one of the new features wasn't yet merged. Now that it is I'll update this PR.

The reason I've reworked some of my previous additions to this page is that I feel a bit insecure writing documentation. When I read some parts of it, it feels too verbose or more intricate than necessary. Your judgement on this would help me. Thanks.

@berarma berarma force-pushed the playing_videos_4.5 branch from eadf5b8 to 0d450ef Compare June 9, 2025 11:32
@berarma berarma force-pushed the playing_videos_4.5 branch from 0d450ef to 3abcd3b Compare June 9, 2025 11:39
@berarma berarma marked this pull request as ready for review June 9, 2025 11:47
@berarma
Copy link
Contributor Author

berarma commented Jun 9, 2025

Description updated.

@AThousandShips AThousandShips added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:animation labels Jun 9, 2025
@AThousandShips AThousandShips added this to the 4.5 milestone Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:animation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants