Skip to content

Fix AnimationPlayer finished state in the editor #107244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Jun 6, 2025

@TokageItLab TokageItLab force-pushed the fix-animplayeredit-finish branch from bdf0d10 to 848ab8c Compare June 7, 2025 13:06
@TokageItLab TokageItLab force-pushed the fix-animplayeredit-finish branch from 848ab8c to d5ac08b Compare June 7, 2025 15:02
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

State machines tend to be convoluted so I hope it works without systematically diagramming and looking for missing cases. Approved.

@TokageItLab TokageItLab moved this from Ready for review to Approved, Waiting for Production in Animation Team Issue Triage Jun 7, 2025
@akien-mga akien-mga merged commit c6c6b2e into godotengine:master Jun 8, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from Approved, Waiting for Production to Done in Animation Team Issue Triage Jun 8, 2025
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

AnimationPlayer animation skips to the beginning and changes the values when finished in the editor
4 participants