Gradle init script improvements #121
Conversation
|
@etiennestuder I've made the init-scripts as close as I can to the "gold standard" without too many contortions. There are some fundamental differences that make it hard to get closer (ie the build-validation scripts always override the GE server config, but the TC scripts only do this when adding GE to a non-GE project). I guess a next step could be to try to enable build-validation for projects using Gradle < 5. I haven't tested this because I don't currently have a GE server that allows anonymous publishing, and Gradle 4 doesn't support authentication. |
|
|
||
| clearWarnings() | ||
|
|
||
| // define a buildScanPublished listener that captures the build scan URL and sends it in a message to the server |
There was a problem hiding this comment.
-1: Looks like an inaccurate comment.
There was a problem hiding this comment.
Good point. This was copied from the "Gold standard" script and should be modified as appropriate
bigdaz
force-pushed
the
dd/init-script-cleanup
branch
from
9c12129 to
799c75f
Compare
|
I'll take a look over the week-end while in the air. |
|
@etiennestuder Are you still interested in these changes? If so I can rebase and resolve and conflicts. |
|
@bigdaz I'm very mnuch still interested. Just did not get to it, yet. Thanks for resolving the coflicts (I belive it's only chnaged versions of GE and CCUD plugin). |
Loading the GE plugin into the initscript classpath is not required.
Removes the separate 'capture-published-build-scan.gradle' init script, merging the functionality into 'configure-gradle-enterprise.gradle'. This reduces duplication and simplifies the overall scripts.
Borrowing the logic from the TC Build Scan plugin, the init-script now checks if the GE / CCUD plugins are already applied.
This reduces duplication and increases similarity with TC Build Scan plugin.
bigdaz
force-pushed
the
dd/init-script-cleanup
branch
from
799c75f to
90b755a
Compare
|
@etiennestuder PR has been rebased on |
|
Closing this PR in favor of #264 |
Various refactorings and improvements to the init-scripts used to instrument Gradle:
-e).-e.As well as improving init-script behaviour, these increase the similarity between init-scripts in this project and the TC Build Scan plugin.