Skip to content

Remove special Maven check when -e is used #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

erichaagdev
Copy link
Member

@erichaagdev erichaagdev commented Dec 20, 2022

Tests

Maven

./02-validate-local-build-caching-different-locations.sh \
  -r https://github.com/apache/maven \
  -g package -x -e

image


./02-validate-local-build-caching-different-locations.sh \
  -r https://github.com/apache/maven \
  -g package -e

image


./02-validate-local-build-caching-different-locations.sh \
  -r https://github.com/apache/maven \
  -g package -e -s https://ge.solutions-team.gradle.com

image

Gradle

./03-validate-local-build-caching-different-locations.sh \
  -r https://github.com/etiennestuder/java-ordered-properties \
  -t assemble -b no-ge -x -e

image


./03-validate-local-build-caching-different-locations.sh \
  -r https://github.com/etiennestuder/java-ordered-properties \
  -t assemble -b no-ge -e

image


./03-validate-local-build-caching-different-locations.sh \
  -r https://github.com/etiennestuder/java-ordered-properties \
  -t assemble -b no-ge -e -s https://ge.solutions-team.gradle.com

image

@erichaagdev erichaagdev self-assigned this Dec 20, 2022
@etiennestuder
Copy link
Member

@erichaagdev Before merging, please do a counter-test where publishing is enabled (and same on the Gradle side). If all is good, merge it. Thanks.

@erichaagdev
Copy link
Member Author

@etiennestuder additional tests ran. Results have been added to the description.

Merging.

@erichaagdev erichaagdev merged commit f22b1fc into main Dec 20, 2022
@erichaagdev erichaagdev deleted the erichaagdev/remove-enable-ge-special-maven-handling branch December 20, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants