Skip to content

Logging level when fetching Build Scan data from Gradle Enterprise is incorrect #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

erichaagdev
Copy link
Member

This change fixes a regression introduced by #383 where the conditions under which --brief-logging were incorrectly switched.

Behavior in v2.3.2 (correct)

image

Behavior in v2.3.3 (incorrect)

image

Behavior with these changes (correct)

image

@erichaagdev erichaagdev self-assigned this Apr 12, 2023
@erichaagdev erichaagdev changed the title Brief logging condition is flipped Logging level when fetching Build Scan data from Gradle Enterprise is incorrect Apr 12, 2023
Copy link
Member

@etiennestuder etiennestuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erichaagdev erichaagdev merged commit f0b8b5d into main Apr 12, 2023
@erichaagdev erichaagdev deleted the erichaagdev/fix-brief-logging branch April 12, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants