Skip to content

Add composite actions to run the experiments #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Apr 27, 2022

Conversation

jprinet
Copy link
Member

@jprinet jprinet commented Mar 11, 2022

Copy link
Member

@jthurne jthurne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are super-cool!

Signed-off-by: Jerome Prinet <jprinet@gradle.com>
@jprinet jprinet force-pushed the feature/expe_as_composite_actions branch from 8f7ec59 to 20d23e4 Compare March 11, 2022 16:14
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
@jprinet jprinet force-pushed the feature/expe_as_composite_actions branch from b2f6ac2 to 02ebe59 Compare March 14, 2022 09:23
@runningcode
Copy link
Contributor

Thanks Jerome. This looks good overall but two things:

I think we want these to exist in this repository: https://github.com/gradle/gradle-enterprise-build-optimization-experiments

The other requirement (from the ticket) is that we want each project to be its own Github workflow. This will allow better re-use of these from different teams so they can copy them to their use case.
That being said, this might also be suitable. I will let @etiennestuder decide.

@jprinet
Copy link
Member Author

jprinet commented Mar 14, 2022

I think we want these to exist in this repository: https://github.com/gradle/gradle-enterprise-build-optimization-experiments

My impression is that the repo providing the scripts should be the one providing the composite actions to use them. This would reduce the risk of desynchronization.

The other requirement (from the ticket) is that we want each project to be its own Github workflow. This will allow better re-use of these from different teams so they can copy them to their use case. That being said, this might also be suitable. I will let @etiennestuder decide.

So far, there is no need to separate the workflows per project, Androidx might become special though. Having one single skeleton to maintain would reduce code duplication.

@etiennestuder
Copy link
Member

@jprinet let's please start simple. there is no need to do more than what we want for the OSS projects. it's also much simpler to review and evolve this way.

@jprinet
Copy link
Member Author

jprinet commented Mar 14, 2022

My idea was to have an optional input when requiring wsl-bash however, the step just fails when the interpreter is not present.
We could have some dedicated composite with the wsl-bash, which would require the caller to handle the conditional call.

@jprinet let's please start simple. there is no need to do more than what we want for the OSS projects. it's also much simpler to review and evolve this way.

Absolutely @etiennestuder, we'll keep it as is for the moment and we can consider integrating with the cross platform tests as another task.

@jprinet jprinet force-pushed the feature/expe_as_composite_actions branch from bf296a3 to 02ebe59 Compare March 14, 2022 13:47
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
@jprinet jprinet force-pushed the feature/expe_as_composite_actions branch from 8b53a6d to 505723b Compare March 22, 2022 16:43
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
@jprinet jprinet force-pushed the feature/expe_as_composite_actions branch from 505723b to 10e3bf2 Compare March 23, 2022 10:19
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
@jprinet jprinet force-pushed the feature/expe_as_composite_actions branch 11 times, most recently from d3d1172 to b35bb47 Compare March 25, 2022 09:55
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
@jprinet jprinet force-pushed the feature/expe_as_composite_actions branch from b35bb47 to d381ba5 Compare March 25, 2022 09:56
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
@jprinet jprinet force-pushed the feature/expe_as_composite_actions branch from d2f82c0 to f60a8dd Compare April 19, 2022 14:09
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
@jprinet jprinet force-pushed the feature/expe_as_composite_actions branch 15 times, most recently from 1cd9724 to cc15e92 Compare April 20, 2022 10:22
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
@jprinet jprinet force-pushed the feature/expe_as_composite_actions branch from cc15e92 to d84c36c Compare April 20, 2022 10:26
@etiennestuder etiennestuder merged commit a9ae9bd into gradle:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants