-
Notifications
You must be signed in to change notification settings - Fork 23
Add composite actions to run the experiments #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add composite actions to run the experiments #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are super-cool!
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
8f7ec59
to
20d23e4
Compare
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
b2f6ac2
to
02ebe59
Compare
Thanks Jerome. This looks good overall but two things: I think we want these to exist in this repository: https://github.com/gradle/gradle-enterprise-build-optimization-experiments The other requirement (from the ticket) is that we want each project to be its own Github workflow. This will allow better re-use of these from different teams so they can copy them to their use case. |
My impression is that the repo providing the scripts should be the one providing the composite actions to use them. This would reduce the risk of desynchronization.
So far, there is no need to separate the workflows per project, Androidx might become special though. Having one single skeleton to maintain would reduce code duplication. |
@jprinet let's please start simple. there is no need to do more than what we want for the OSS projects. it's also much simpler to review and evolve this way. |
My idea was to have an optional input when requiring
Absolutely @etiennestuder, we'll keep it as is for the moment and we can consider integrating with the cross platform tests as another task. |
bf296a3
to
02ebe59
Compare
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
8b53a6d
to
505723b
Compare
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
505723b
to
10e3bf2
Compare
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
d3d1172
to
b35bb47
Compare
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
b35bb47
to
d381ba5
Compare
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
d2f82c0
to
f60a8dd
Compare
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
1cd9724
to
cc15e92
Compare
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
cc15e92
to
d84c36c
Compare
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
…ns' into feature/expe_as_composite_actions * jprinet/feature/expe_as_composite_actions: CR follow-up: Align experiments 2 and 3 with experiment 1
Relates to https://github.com/gradle/ge/issues/13584