Predictive Test Selection is disabled when running builds #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichaagdev
force-pushed
the
erichaagdev/disable-pts
branch
from
2166ae6 to
0c35bfb
Compare
|
@etiennestuder I want to make sure you see the note I have in the description:
I think that is the desired state but it means we need to recommend users also disable PTS in the CI builds. Should we also update the wording then of the interactive mode to include this? |
jthurne
approved these changes
Oct 20, 2023
erichaagdev
force-pushed
the
erichaagdev/disable-pts
branch
from
0c35bfb to
7f582dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the system property
-Dpts.enabled=falseto build invocations in order to disable PTS. The displayed invocation commands have also been updated to include the system property.ℹ️ Note: The CI/Local experiments (
exp5-gradle&exp4-maven) will also be invoked with-Dpts.enabled=falseeven if the original CI build did not have PTS disabled.Closes #522