Skip to content

Github actions access token migration #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-verification.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
distribution: 'adopt'
- name: Set up Gradle
uses: gradle/gradle-build-action@v3
with:
develocity-access-key: ${{ secrets.DV_SOLUTIONS_ACCESS_KEY }}
- name: Build with Gradle
run: ./gradlew build -i
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a change you introduced, but I'm wondering if logging at info level is necessary

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be removed.

env:
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_SOLUTIONS_ACCESS_TOKEN }}
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
distribution: 'adopt'
- name: Set up Gradle
uses: gradle/gradle-build-action@v3
with:
develocity-access-key: ${{ secrets.DV_SOLUTIONS_ACCESS_KEY }}
- name: Build with Gradle
run: ./gradlew build
env:
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_SOLUTIONS_ACCESS_TOKEN }}
- name: Upload built script artifacts
uses: actions/upload-artifact@v4
with:
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:
run:
shell: ${{ matrix.shell }} {0}
env:
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_SOLUTIONS_ACCESS_TOKEN }}
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.DV_SOLUTIONS_ACCESS_KEY }}
WSLENV: GRADLE_ENTERPRISE_ACCESS_KEY
steps:
- name: Set up WSL
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ jobs:
run:
shell: ${{ matrix.shell }} {0}
env:
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_SOLUTIONS_ACCESS_TOKEN }}
WSLENV: GRADLE_ENTERPRISE_ACCESS_KEY
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.DV_SOLUTIONS_ACCESS_KEY }}
WSLENV: GRADLE_ENTERPRISE_ACCESS_KEY
steps:
- name: Set up WSL
if: ${{ runner.os == 'Windows' }}
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/development-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ jobs:
distribution: 'adopt'
- name: Set up Gradle
uses: gradle/gradle-build-action@v3
with:
develocity-access-key: ${{ secrets.DV_SOLUTIONS_ACCESS_KEY }}
- name: Build with Gradle
run: ./gradlew build githubRelease -i
env:
GITHUB_ACCESS_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_SOLUTIONS_ACCESS_TOKEN }}
3 changes: 2 additions & 1 deletion .github/workflows/production-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ jobs:
distribution: 'adopt'
- name: Set up Gradle
uses: gradle/gradle-build-action@v3
with:
develocity-access-key: ${{ secrets.DV_SOLUTIONS_ACCESS_KEY }}
- name: Build with Gradle
run: ./gradlew build githubRelease -PfinalRelease -i
env:
GITHUB_ACCESS_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_SOLUTIONS_ACCESS_TOKEN }}
Loading