-
Notifications
You must be signed in to change notification settings - Fork 23
Add symbolic link to latest run #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
834864b
to
f5b01e8
Compare
components/scripts/lib/init.sh
Outdated
@@ -6,6 +6,13 @@ make_experiment_dir() { | |||
rm -f "${BUILD_SCAN_FILE}" | |||
} | |||
|
|||
create_alias_latest() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest renaming this to make_symlink_to_latest_experiment_dir
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
My last remaining concern @jthurne is about the behavior on Windows OS. |
Currently, we only support running the scripts using the Windows Subsystem for Linux (WSL), which does support symbolic links. So we should be good.
LGTM. |
@jprinet don't forget to update |
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
Just done, please confirm you're fine with the wording 👍 |
Co-authored-by: Jim Hurne <hurne_jim@yahoo.com>
This will help to simplify automation around the scripts, not having to deal with a randomly named experiment directory
Signed-off-by: Jerome Prinet jprinet@gradle.com