Skip to content

Add symbolic link to latest run #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Conversation

jprinet
Copy link
Member

@jprinet jprinet commented Apr 25, 2022

This will help to simplify automation around the scripts, not having to deal with a randomly named experiment directory

Signed-off-by: Jerome Prinet jprinet@gradle.com

@jprinet jprinet requested a review from jthurne April 25, 2022 10:08
Signed-off-by: Jerome Prinet <jprinet@gradle.com>
@jprinet jprinet force-pushed the jprinet/latest_link branch from 834864b to f5b01e8 Compare April 25, 2022 10:15
@@ -6,6 +6,13 @@ make_experiment_dir() {
rm -f "${BUILD_SCAN_FILE}"
}

create_alias_latest() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest renaming this to make_symlink_to_latest_experiment_dir

Signed-off-by: Jerome Prinet <jprinet@gradle.com>
@jprinet
Copy link
Member Author

jprinet commented Apr 26, 2022

My last remaining concern @jthurne is about the behavior on Windows OS.
I added some error redirection to avoid error messages, the link wouldn't be created as a worse case scenario.

@jthurne
Copy link
Member

jthurne commented Apr 26, 2022

My last remaining concern @jthurne is about the behavior on Windows OS.

Currently, we only support running the scripts using the Windows Subsystem for Linux (WSL), which does support symbolic links. So we should be good.

I added some error redirection to avoid error messages, the link wouldn't be created as a worse case scenario.

LGTM.

@jthurne
Copy link
Member

jthurne commented Apr 26, 2022

@jprinet don't forget to update release/changes.md.

Signed-off-by: Jerome Prinet <jprinet@gradle.com>
@jprinet
Copy link
Member Author

jprinet commented Apr 26, 2022

@jprinet don't forget to update release/changes.md.

Just done, please confirm you're fine with the wording 👍

Co-authored-by: Jim Hurne <hurne_jim@yahoo.com>
@jprinet jprinet merged commit 9f3db56 into gradle:main Apr 26, 2022
@jprinet jprinet deleted the jprinet/latest_link branch April 26, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants