Skip to content

Scalar type for UUID #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Conversation

ravikancherla
Copy link

A new scalar type of id - UUID is added

  • Accepts string value or UUID value that will be converted to java.util.UUID at runtime
  • Added groovy test cases
  • Updated documentation

Relates to #4

@ravikancherla
Copy link
Author

@bbakerman - Any idea when this PR can be looked into ?

@ketiko
Copy link

ketiko commented Jun 3, 2020

This would be great to have.

@plaurina
Copy link

plaurina commented Dec 2, 2020

Bump.

Wanting to make sure I'm helping to show there is public interest in getting this merged in.
Thank you @ravikancherla for coding it up - I am currently using it.

This PR has been open for a year, if there's any of requirements for getting this approved that I can help with I'd be open to working to get it to meet them if @ravikancherla has disappeared/lost interest and the admins want help to move this along.

@ravikancherla
Copy link
Author

@plaurina - as far as I know I have passed all the checks and have been waiting for admins to merge this PR for over an year 😊

Of course with conflicts because of new changes happened after that. Feel free to resolve the conflicts. I think that’s all is needed from our side and admins have to merge this PR after that

Copy link

@guissalustiano guissalustiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT

@bbakerman bbakerman mentioned this pull request Feb 24, 2022
@bbakerman bbakerman merged commit ea81b1f into graphql-java:master Feb 25, 2022
@bbakerman
Copy link
Member

technically via #55 - but it started from this code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants