AttributeDict could not pickle #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 89.03% 89.54% +0.51%
==========================================
Files 3 3
Lines 155 153 -2
==========================================
- Hits 138 137 -1
+ Misses 17 16 -1
Continue to review full report at Codecov.
|
|
Add unittest to reproduce and simply remove reduce to fix it. |
Ledenel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to python pickle, object containing pickable object (Including AttributeDict) should pickle.
But
AttributeDictimplements__reduce__which override the origin pickle process, and even call__reduce__on__dict__doesn't actually pickle a dict. Instead, it will throwTypeError: can't pickle dict objectseven the__dict__itself is pickable.