Add tests for references to record fields and update symbol retrieval to only include source nodes #4641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulomoon
changed the title
References to record fields gives too many results This commit adds tests for references to record fields and updates the symbol retrieval logic to ensure that references to record fields are handled correctly. The changes is small: - The `getNamesAtPoint` function in `AtPoint.hs` now only searches for `Name` that are in the source node from `HieAst`.
soulomoon
force-pushed
the
4412-textdocumentreferences-on-a-record-field-in-a-definition-returns-way-too-many-things-with-ghc-964
branch
from
1e912c3 to
8277c93
Compare
…eld-in-a-definition-returns-way-too-many-things-with-ghc-964
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:You may have to fix your CI before adding the pull request to the queue again. |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4412
Very small change, Change
getNamesAtPointto only include names in the source.